This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
common-io: Refactoring and updates to RTC test cases and top-level header file #1977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiutongs
previously approved these changes
May 8, 2020
vjjunnut
reviewed
May 11, 2020
| xSetDateTime.usYear = testIotRTC_DEFAULT_CURRENT_YEAR; | ||
| xSetDateTime.ucMonth = testIotRTC_DEFAULT_CURRENT_MONTH; | ||
| xSetDateTime.ucDay = testIotRTC_DEFAULT_CURRENT_DAY; | ||
| xSetDateTime.ucHour = testIotRTC_DEFAULT_CURRENT_HOUR; | ||
| xSetDateTime.ucMinute = testIotRTC_DEFAULT_CURRENT_MINUTE; | ||
| xSetDateTime.ucSecond = testIotRTC_DEFAULT_CURRENT_SECOND; | ||
| xSetDateTime.ucSecond = testIotRTC_DEFAULT_CURRENT_SECOND + testIotRTC_DEFAULT_ALARM_TIME; |
There was a problem hiding this comment.
Why is the DEFAULT_ALARM_TIME added here to the default time being set? #722 may not return error if its the current second.
There was a problem hiding this comment.
The reason is due to the fact that testIotRTC_DEFAULT_CURRENT_SECOND is zero. The original setup would subtract 5 from 0 in a uint8 causing a underflow. That said, it could be a good idea to bump it so that xSetDateTime.ucSecond > testIotRTC_DEFAULT_ALARM_TIME.
You agree with bumping it to say 2 * testIotRTC_DEFAULT_ALARM_TIME? Alternatively, set testIotRTC_DEFAULT_CURRENT_SECOND > testIotRTC_DEFAULT_ALARM_TIME.
There was a problem hiding this comment.
Yes. Didnt realize that. I agree to either of the approach
vjjunnut
previously approved these changes
May 13, 2020
|
/bot run checks |
qiutongs
force-pushed
the
fix/common-io-rtc-test
branch
from
cab6b7a to
571f87a
Compare
|
/bot run checks |
added 2 commits
May 14, 2020 14:02
…on how the test was setup. Refactored tests to use TEST_PROTECT sections, init all values of the date/time struct and not having 'eternal block' on semaphores
…RtcSetAlarmInvalid test-case as it needs to setup alarm ni the past.
qiutongs
force-pushed
the
fix/common-io-rtc-test
branch
from
571f87a to
d4bfe4f
Compare
|
/bot run checks |
1 similar comment
|
/bot run checks |
qiutongs
approved these changes
May 15, 2020
cobusve
approved these changes
May 19, 2020
alfred2g
pushed a commit
to alfred2g/amazon-freertos
that referenced
this pull request
May 21, 2020
…ader file (aws#1977) * Updated iot_rtc.h documentation to cover expected return value based on how the test was setup. Refactored tests to use TEST_PROTECT sections, init all values of the date/time struct and not having 'eternal block' on semaphores * Changed default seconds value from 0 to 10 to better fit the AFQP_IotRtcSetAlarmInvalid test-case as it needs to setup alarm ni the past. Co-authored-by: Max Wennerfeldt <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.