Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Unit Testing on boarding readme #1988

Merged
merged 2 commits into from
May 21, 2020
Merged

Unit Testing on boarding readme #1988

merged 2 commits into from
May 21, 2020

Conversation

alfred2g
Copy link
Contributor

@alfred2g alfred2g commented May 8, 2020

Unit Testing on boarding readme

Description

Steps to follow to onboard unit testing with cmake, cmock and unity

Checklist:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@alfred2g alfred2g requested review from lundinc2 and dachalco May 10, 2020 19:14
@alfred2g alfred2g requested a review from lundinc2 May 11, 2020 17:02
lundinc2
lundinc2 previously approved these changes May 11, 2020
Copy link
Contributor

@lundinc2 lundinc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

lundinc2
lundinc2 previously approved these changes May 21, 2020
@alfred2g
Copy link
Contributor Author

/bot run checks

Make sure at around line 15 the the Unit Test directory location exists in this case **../../../libraries** if not add it<br>

``` cmake
add_subdirectory(../../../libraries libraries)
Copy link
Contributor

@aggarw13 aggarw13 May 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this just be "add_subdirectory(../../../libraries libraries)"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am not sure if both of them work, the current one is ../../../libraries libraries
it is working just fine

/my/under/test/source/needs
)
```
This compilation step would create an object library called *project_name_real.a*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This statement is redundant as it was mentioned in point 5.

aggarw13
aggarw13 previously approved these changes May 21, 2020
@alfred2g alfred2g requested review from lundinc2 and gkwicker May 21, 2020 21:25
gkwicker
gkwicker previously approved these changes May 21, 2020
@alfred2g alfred2g dismissed stale reviews from gkwicker and aggarw13 via b94b9d7 May 21, 2020 22:30
@alfred2g alfred2g merged commit ee81fe4 into aws:master May 21, 2020
@alfred2g alfred2g deleted the utest_readme branch May 21, 2020 23:20
alfred2g added a commit to alfred2g/amazon-freertos that referenced this pull request Jun 2, 2020
* Test: Add Unit Test Readme.md

* Update README.md

Co-authored-by: Alfred Gedeon <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants