This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
PKCS #11 Unit Tests #1992
Merged
PKCS #11 Unit Tests #1992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Now at 85% line coverage * 100% function coverage * Added unit tests for: * C_GetAttributeValue * PKCS11_PAL_DESTROY_OBJECT * C_Verify * C_GenerateKeyPair * C_GenerateRandom
alfred2g
reviewed
May 11, 2020
Comment on lines
316
to
326
| pvPortMalloc_Stub( pvPkcs11MallocCb ); | ||
| PKCS11_PAL_FindObject_IgnoreAndReturn( 2 ); | ||
| PKCS11_PAL_GetObjectValue_IgnoreAndReturn( CKR_OK ); | ||
| mbedtls_pk_parse_key_IgnoreAndReturn( 0 ); | ||
| PKCS11_PAL_GetObjectValueCleanup_CMockIgnore(); | ||
| pvPortMalloc_Stub( pvPkcs11MallocCb ); | ||
| mbedtls_ecp_keypair_init_CMockIgnore(); | ||
| mbedtls_ecp_group_init_CMockIgnore(); | ||
| mbedtls_ecp_group_load_IgnoreAndReturn( 0 ); | ||
| mbedtls_mpi_read_binary_IgnoreAndReturn( 0 ); | ||
| pvPortMalloc_Stub( pvPkcs11MallocCb ); |
There was a problem hiding this comment.
all the stubs are the same
pvPortMalloc_Stub( pvPkcs11MallocCb );
alfred2g
reviewed
May 11, 2020
| mbedtls_ecp_keypair_init_CMockIgnore(); | ||
| mbedtls_ecp_group_init_CMockIgnore(); | ||
| mbedtls_ecp_group_load_IgnoreAndReturn( 0 ); | ||
| mbedtls_mpi_read_binary_IgnoreAndReturn( 0 ); | ||
| pvPortMalloc_Stub( pvPkcs11MallocCb ); |
There was a problem hiding this comment.
here too,
stubs can only be set at the beginning of the function , no need to redefine them before every function call
There was a problem hiding this comment.
This one should stay the same as I have different behavior in the malloc stub before this one
There was a problem hiding this comment.
pvPortMalloc_IgnoreAndReturn( &xKeyContext ); Above this one injects a struct
alfred2g
reviewed
May 11, 2020
| TEST_ASSERT_EQUAL( CKR_OK, xResult ); | ||
|
|
||
| xResult = prvOpenSession( &xSession ); | ||
| TEST_ASSERT_EQUAL( CKR_OK, xResult ); | ||
|
|
||
| mbedtls_pk_init_CMockIgnore(); | ||
| pvPortMalloc_Stub( pvPkcs11MallocCb ); | ||
| PKCS11_PAL_FindObject_IgnoreAndReturn( 1 ); | ||
| PKCS11_PAL_GetObjectValue_IgnoreAndReturn( CKR_OK ); | ||
| PKCS11_PAL_FindObject_IgnoreAndReturn( CK_INVALID_HANDLE ); | ||
| mbedtls_pk_parse_public_key_IgnoreAndReturn( 0 ); | ||
| PKCS11_PAL_GetObjectValueCleanup_CMockIgnore(); | ||
| pvPortMalloc_Stub( pvPkcs11MallocCb ); |
alfred2g
suggested changes
May 11, 2020
|
/bot run checks |
1 similar comment
|
/bot run checks |
cobusve
approved these changes
May 12, 2020
alfred2g
approved these changes
May 12, 2020
alfred2g
pushed a commit
to alfred2g/amazon-freertos
that referenced
this pull request
May 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.