This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TCP flags are not of proper width according to the header in the TCP protocol.
Description
The TCP flags are not of proper width according to the header in the TCP protocol. In absence of a cast, this value is downcasted from
uin16_t
touint8_t
to assign value to the 8 bit widthxTCP_HEADER.ucTCPFlags
.These flags are designed to fit in a 6-bit wide value according to RFC 793. The other bits are experimental and are defined in various RFCs. They are not used as of now in the +TCP stack except for the purposes of debugging.
The issue that triggered this PR:
Visual Studio build (v142) yields 2 warnings for
FreeRTOS_TCP_IP.c
file, both of which arecast truncates constant value
.Both places downcast macro constants from
uin16_t
touint8_t
to assign value to the 8-bit width xTCP_HEADER.ucTCPFlags member hereChecklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.