This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
PKCS #11 Unit Tests #2007
Merged
PKCS #11 Unit Tests #2007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 100% line coverage for C_Destroy. * More line coverage for attribute parsing. * Refactored common setup and teardown stubs to macros to reduce LOC.
gkwicker
previously approved these changes
May 14, 2020
|
/bot run checks |
alfred2g
reviewed
May 18, 2020
| xResult = prvInitializePkcs11(); \ | ||
| TEST_ASSERT_EQUAL( CKR_OK, xResult ); \ | ||
| xResult = prvOpenSession( &xSession ); \ | ||
| TEST_ASSERT_EQUAL( CKR_OK, xResult ); \ |
alfred2g
previously approved these changes
May 18, 2020
cobusve
reviewed
May 19, 2020
| prvCommonDeinitStubs(); | ||
|
|
||
| /* Since malloc does not require a NULL check, the stub was called one time too many. */ | ||
| usMallocFreeCalls++; |
There was a problem hiding this comment.
Please avoid this by letting the malloc stub check for null and not count when it is null.
…y up in test_pkcs11_C_FindObjectsInitBadArg.
cobusve
approved these changes
May 19, 2020
alfred2g
approved these changes
May 19, 2020
|
/bot run checks |
alfred2g
pushed a commit
to alfred2g/amazon-freertos
that referenced
this pull request
May 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PKCS #11 Unit Tests
Description
Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.