This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Add flash id component to IotFlashInfo struct #2016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lundinc2
reviewed
May 15, 2020
| @@ -94,6 +94,7 @@ typedef struct IotFlashInfo | |||
| * and if sub-sectors of 4k can be write protected then this may be set to 4K*/ | |||
| uint8_t ucAsyncSupported; /*!< Provides a flag to indicate if background erase/program | |||
| * is supported. User must check this before they can setup a callback and wait.*/ | |||
| uint32_t ulFlashID; /*!< flash chip id */ | |||
There was a problem hiding this comment.
Nit: Do you mind changing this to "Flash chip ID."
There was a problem hiding this comment.
The rest flash components like ulFlashSize in the structure are commented without capital F. It is not shown in this diff.
lundinc2
approved these changes
May 15, 2020
qiutongs
approved these changes
May 17, 2020
alfred2g
pushed a commit
to alfred2g/amazon-freertos
that referenced
this pull request
May 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add flash id component to IotFlashInfo struct
Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.