This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Fix nordic freertos timer create #2020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/bot run checks |
qiutongs
previously approved these changes
May 18, 2020
|
/bot run checks |
1 similar comment
|
/bot run checks |
|
Note: Same issue is posted in Nordic forum and the fix is pending in Nordic SDK. Fixing for now in the porting layer, until a proper fix has been merged from upstream. |
gkwicker
suggested changes
May 21, 2020
| @@ -133,27 +134,35 @@ uint32_t app_timer_create(app_timer_id_t const * p_timer_id, | |||
| return NRF_ERROR_INVALID_STATE; | |||
| } | |||
|
|
|||
| if (pinfo->osHandle == NULL) | |||
| /* If already a FreeRTOS timer exists, delete and recreate the timer. */ | |||
There was a problem hiding this comment.
Grammar suggestion: "If a FreeRTOS timer already exists,..."
| if (pinfo->osHandle == NULL) | ||
| err_code = NRF_ERROR_NULL; | ||
| } | ||
| if (mode == APP_TIMER_MODE_SINGLE_SHOT) |
There was a problem hiding this comment.
Please add {...}, also lines 158-160
| pinfo->func = timeout_handler; | ||
| pinfo->osHandle = xTimerCreate(" ", 1000, timer_mode, pinfo, app_timer_callback); | ||
|
|
||
| if (pinfo->osHandle == NULL) |
gkwicker
approved these changes
May 21, 2020
qiutongs
approved these changes
May 21, 2020
|
/bot run checks |
alfred2g
pushed a commit
to alfred2g/amazon-freertos
that referenced
this pull request
May 21, 2020
* Fix nordic freertos timer create function
* Improving comments. include {}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix freertos timer create function for Nordic
Description
Nordic has an implementation for app timer APIs using FreeRTOS timers.
app_timer_createAPI is expected to re-create a new timer with a new handler (note: there is no API to delete a timer). Currently the API returns an error if a timer already exists. With this PR, API ensures if timer is inactive, then delete and create a new timer with the new handler.Also added a check in demo runner to handle user initiated network disable transition in network manager callback.
Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.