This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
OTA - Add private function to free buffers for unhandled events #2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ix file close on OTA resume
| * | ||
| * If there is a valid job id, then a job status update will be sent. | ||
| */ | ||
| * If the job context returned NULL and the image state is not in the self_test state, |
There was a problem hiding this comment.
Are these uncrustify related changes ?
There was a problem hiding this comment.
Yes , they are with the latest config.
gkwicker
suggested changes
May 21, 2020
| * Setting an arbitrarily large base of 0x10000 and masking off that base allows | ||
| * us to do the same thing as a zero offset without the lint warnings of using a | ||
| * null pointer. No structure is anywhere near 64K in size. | ||
| */ | ||
| /*lint -emacro((923,9078),OFFSET_OF) Intentionally cast pointer to uint32_t because we are using it as an offset. */ | ||
|
|
||
| #define OFFSET_OF( t, e ) ( ( uint32_t ) ( &( ( t * ) 0x10000UL )->e ) & 0xffffUL ) |
There was a problem hiding this comment.
Why are we reinventing offsetof()? It is available in C89.
| * | ||
| * If there is a valid job id, then a job status update will be sent. | ||
| */ | ||
| * If the job context returned NULL and the image state is not in the self_test state, |
| */ | ||
| static void prvHandleUnexpectedEvents( OTA_EventMsg_t * pxEventMsg ) | ||
| { | ||
| DEFINE_OTA_METHOD_NAME( "prvHandleUnexpectedEvents" ); |
There was a problem hiding this comment.
Consider configASSERT( pxEventMsg );
There was a problem hiding this comment.
Changed in ec0eaa3
ravibhagavandas
approved these changes
May 21, 2020
gkwicker
approved these changes
May 21, 2020
| */ | ||
| static void prvHandleUnexpectedEvents( OTA_EventMsg_t * pxEventMsg ) | ||
| { | ||
| DEFINE_OTA_METHOD_NAME( "prvHandleUnexpectedEvents" ); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change add a private function to free buffers for unexpected job and data events. The change also fixes file close when OTA resumes.
Description
Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.