This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Only compile prvReadSackOption() when TCP sliding windows are used #2029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 22, 2020 18:22
This was referenced May 24, 2020
|
/bot run checks |
|
The build errors were due to license problem on our test infra. We are in the process of buying new license for Nuvoton. Once that is done, I will re-run the build checks. |
|
/bot run checks Re ran checks after the Keil related build checks were removed. |
AniruddhaKanhere
approved these changes
May 26, 2020
You might forget removing the cmake build checks? |
Actually I did not remove them. Just saw that Pavan said that the checks have been removed and went ahead. I do not have permissions to remove the checks. :) |
qiutongs
approved these changes
May 26, 2020
cobusve
approved these changes
May 26, 2020
qiutongs
pushed a commit
that referenced
this pull request
May 27, 2020
* Only compile prvReadSackOption() when TCP sliding windows are used (#2029) * Repairing a broken CBMC patch file, thanks to Aniruddha Co-authored-by: Hein Tibosch <[email protected]> * Update Nuvoton ethernet project file Co-authored-by: qiutongs <songqt01@gmail,com>
alfred2g
pushed a commit
to alfred2g/amazon-freertos
that referenced
this pull request
Jun 2, 2020
…ws#2029) * Only compile prvReadSackOption() when TCP sliding windows are used (ipconfigUSE_TCP_WIN ) * Repairing a broken CBMC patch file, thanks to Aniruddha Co-authored-by: Hein Tibosch <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make compilation of
prvReadSackOption()dependent onipconfigUSE_TCP_WINDescription
Since the function
prvCheckOptions()was split-up into smaller parts, the functionprvReadSackOption()was compiled unconditionally.Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.