Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature store test #1832

Merged
merged 5 commits into from
Dec 6, 2020
Merged

Feature store test #1832

merged 5 commits into from
Dec 6, 2020

Conversation

hongshanli23
Copy link
Contributor

Issue #, if available:

Description of changes:

  1. Added required polices
  2. Avoid cross region error by pulling the xgboost image from us-east-2 and push to user's default ECR

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-examples-processing
  • Commit ID: afeff66
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: amazon-sagemaker-examples-pr
  • Commit ID: afeff66
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

@paul-cb paul-cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@paul-cb paul-cb merged commit 6a8a4a2 into aws:master Dec 6, 2020
ajaykarpur added a commit that referenced this pull request Dec 8, 2020
* feature: add notebooks for re:Invent 2020 (#1812)

* add new notebooks to website; reveal image guide (#1813)

* change: Move Pipeline example notebook from sagemaker-python-sdk to sagemaker-pipelines (#1818)

Co-authored-by: Payton Staub <[email protected]>

* Feature store test (#1832)

* added script to pull xgboost image from public ecr

* removed dataset

* added script to push to private ecr

* add policies

* tested end-to-end

* removed pip install sagemaker (#1833)

* add new notebooks

* update training menu

Co-authored-by: Ajay Karpur <[email protected]>
Co-authored-by: Payton Staub <[email protected]>
Co-authored-by: Payton Staub <[email protected]>
Co-authored-by: Hongshan Li <[email protected]>
Co-authored-by: Paul B <[email protected]>
ajaykarpur pushed a commit that referenced this pull request Dec 8, 2020
* added script to pull xgboost image from public ecr

* removed dataset

* added script to push to private ecr

* add policies

* tested end-to-end
@hongshanli23 hongshanli23 deleted the feature-store-test branch January 26, 2021 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants