Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HostNetworking Test for PPSG in test agent #1720

Merged
merged 4 commits into from
Dec 9, 2021
Merged

Add HostNetworking Test for PPSG in test agent #1720

merged 4 commits into from
Dec 9, 2021

Conversation

cgchinmay
Copy link
Contributor

What type of PR is this?
feature

Which issue does this PR fix:
N/A

What does this PR do / Why do we need it:
Support for testing HostNetworking for PPSG

Testing done on this change:

ginkgo -v -r -- --cluster-kubeconfig=/Users/cgadgil/.kube/config --cluster-name=cni-ppsg --aws-region=us-west-2 --aws-vpc-id=vpc-04801d95a500e4c9e

STEP: creating test namespace
STEP: creating the Security Group Policy
STEP: creating a deployment to launch pod using Branch ENI
STEP: getting the list of pods using BranchENI
STEP: generating the pod networking validation input to be passed to tester
STEP: validating host networking setup is setup correctly
STEP: creating pod to test host networking setup
2021/11/01 20:13:31 list of pod against which test will be run [{deployment-test-77bddd7895-wh98h cni-automation 192.168.4.26  false} {deployment-test-77bddd7895-c6689 cni-automation 192.168.10.105  false} {deployment-test-77bddd7895-fffcf cni-automation 192.168.1.64  false} {deployment-test-77bddd7895-z75fn cni-automation 192.168.23.207  false} {deployment-test-77bddd7895-9ktdj cni-automation 192.168.11.213  false}]
2021/11/01 20:13:31 testing networking is setup for pods using security groups
2021/11/01 20:13:31 testing for Pod name: deployment-test-77bddd7895-wh98h Namespace: cni-automation, IP: 192.168.4.26
2021/11/01 20:13:31 Found Valid MTU value:9001 for pod: deployment-test-77bddd7895-wh98h on veth Pair: vlan2536b2173ed
2021/11/01 20:13:31 found veth pair vlan2536b2173ed in host network namespace in up state with index 14
2021/11/01 20:13:31 Found correct number(3) of routes in vlanTable: 101 for podIP: 192.168.4.26
....
.....
2021/11/01 20:14:38 testing for Pod name: deployment-test-77bddd7895-9ktdj Namespace: cni-automation, IP: 192.168.11.213
2021/11/01 20:14:38 veth pair vlanc3c7ff42542 not found for the pod: Link not found
2021/11/01 20:14:38 no leaked resource found for the pod cni-automation/deployment-test-77bddd7895-9ktdj

Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No

Does this change require updates to the CNI daemonset config files to work?:

No

Does this PR introduce any user-facing change?:

No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

jayanthvn
jayanthvn approved these changes Nov 2, 2021
View reviewed changes
Copy link
Contributor

@jayanthvn jayanthvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cgchinmay cgchinmay changed the title Add HostNetworking Test for PPSG in test agent [Update agent after merging this PR] Add HostNetworking Test for PPSG in test agent Nov 3, 2021
@cgchinmay cgchinmay requested a review from jayanthvn November 10, 2021 19:14
@cgchinmay cgchinmay requested a review from a team as a code owner December 7, 2021 13:48
@cgchinmay cgchinmay merged commit 86ece93 into aws:master Dec 9, 2021
cgchinmay pushed a commit to cgchinmay/amazon-vpc-cni-k8s that referenced this pull request Dec 9, 2021
Add HostNetworking Test for PPSG in test agent (aws#1720)
60dafc0 
* Add HostNetworking Test for PPSG in test agent

* Updated PPSG test to validate vlan.eth link
cgchinmay pushed a commit to cgchinmay/amazon-vpc-cni-k8s that referenced this pull request Dec 9, 2021
merge conflicts with cni-metrics-helper chart
e394298 
Fix compilation errors (aws#1751)

add support for running canary script in different regions (aws#1752)

Regenerate pod eni values for new instance types (aws#1754)

* Regenerate pod eni values for new instance types

Co-authored-by: Senthil Kumaran <[email protected]>

Closed issue message (aws#1761)

* closed issue message

* update message

fix typo in upload script (aws#1763)

Update calico file path

Use an unique s3 bucket name (aws#1760)

Update region

Workflow to build arm and x86 images (aws#1764)

DataStore.GetStats() refactoring to simplify adding new fields (aws#1704)

* DataStore.GetStats() refactoring to simplify adding new fields

* cleanup

* cleanup

* cleanup

* goimports

* rename test to TestGetStatsV4

* address comments

* fix typo

* update

* update "IP pool is too low" logging

* GetStats() -> GetIpStats()

* GetStats() -> GetIpStats() in tests and comments

* update test

* cleanup test

* add logPoolStats comment

Fix KOPS_STATE_STORE (aws#1770)

Automation script for running IT  (aws#1759)

Update issue template

Update issue template with email address

Update issue template

Update go.mod for integration folder (aws#1741)

* Update go.mod for integration folder

- Update go.mod for integration folder

* Change integration test to use new K8s test framework

* Modify server pod image

* Switch to Nginx port 80 for server pod

* Switch server port in client test

* Remove custom command directive for Nginx pod

* Added ping command for host checks

README: mention arn:aws:iam::aws:policy/AmazonEKS_CNI_Policy (aws#1768)

Co-authored-by: Shreya027 <[email protected]>

Add dl1.24xlarge to ENILimits override list (aws#1777)

Chart and Manifest updates (aws#1771)

* Chart and Manifest updates

* Update probe timeout values

Change workflow to use git install (aws#1785)

- Change workflow to use git install as the go get command was
  altering go.mod file without updating go.sum file

Add HostNetworking Test for PPSG in test agent  (aws#1720)

* Add HostNetworking Test for PPSG in test agent

* Updated PPSG test to validate vlan.eth link
cgchinmay pushed a commit that referenced this pull request Jan 27, 2022
Fetch Region and CLUSTER_ID information from cni-metrics-helper env (#…
852d811 
…1715)

* merge conflicts with cni-metrics-helper chart

Fix compilation errors (#1751)

add support for running canary script in different regions (#1752)

Regenerate pod eni values for new instance types (#1754)

* Regenerate pod eni values for new instance types

Co-authored-by: Senthil Kumaran <[email protected]>

Closed issue message (#1761)

* closed issue message

* update message

fix typo in upload script (#1763)

Update calico file path

Use an unique s3 bucket name (#1760)

Update region

Workflow to build arm and x86 images (#1764)

DataStore.GetStats() refactoring to simplify adding new fields (#1704)

* DataStore.GetStats() refactoring to simplify adding new fields

* cleanup

* cleanup

* cleanup

* goimports

* rename test to TestGetStatsV4

* address comments

* fix typo

* update

* update "IP pool is too low" logging

* GetStats() -> GetIpStats()

* GetStats() -> GetIpStats() in tests and comments

* update test

* cleanup test

* add logPoolStats comment

Fix KOPS_STATE_STORE (#1770)

Automation script for running IT  (#1759)

Update issue template

Update issue template with email address

Update issue template

Update go.mod for integration folder (#1741)

* Update go.mod for integration folder

- Update go.mod for integration folder

* Change integration test to use new K8s test framework

* Modify server pod image

* Switch to Nginx port 80 for server pod

* Switch server port in client test

* Remove custom command directive for Nginx pod

* Added ping command for host checks

README: mention arn:aws:iam::aws:policy/AmazonEKS_CNI_Policy (#1768)

Co-authored-by: Shreya027 <[email protected]>

Add dl1.24xlarge to ENILimits override list (#1777)

Chart and Manifest updates (#1771)

* Chart and Manifest updates

* Update probe timeout values

Change workflow to use git install (#1785)

- Change workflow to use git install as the go get command was
  altering go.mod file without updating go.sum file

Add HostNetworking Test for PPSG in test agent  (#1720)

* Add HostNetworking Test for PPSG in test agent

* Updated PPSG test to validate vlan.eth link

* Minor change to logging CLUSTER_ID and Region values
Fix for cni-metrics-helper failing integration test

* Fixed merge conflicts

* Readme update

* Updated Readme with more description of AWS_CLUSTER_ID

* minor change
haouc pushed a commit to haouc/amazon-vpc-cni-k8s that referenced this pull request Feb 9, 2022
@haouc
Add HostNetworking Test for PPSG in test agent (aws#1720)
bc907c6 
* Add HostNetworking Test for PPSG in test agent

* Updated PPSG test to validate vlan.eth link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achevuru achevuru Awaiting requested review from achevuru

@jayanthvn jayanthvn Awaiting requested review from jayanthvn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgchinmay @jayanthvn