Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow to build arm and x86 images #1764

Merged
merged 1 commit into from
Nov 24, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions .github/workflows/build-multi-arch.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
name: Build x64 and ARM64 images

on:
pull_request:
branches:
- 'master'
- 'release*'

jobs:
build_x64:
name: Build x64
runs-on: [self-hosted, linux, x64]
steps:

- name: Set up Go 1.14
uses: actions/setup-go@v2
with:
go-version: '1.14.3'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In our make file , we build with go 1.16

https://github.com/aws/amazon-vpc-cni-k8s/blob/master/Makefile#L64

Does the worker version go-1.14 have any significance or relevance? Because we do make docker ... the targets below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there is any relevance. It is mainly to pull the code into go directory.

id: go

- name: Check out code into the Go module directory
uses: actions/checkout@v2

- name: Build
run: make docker all

build_arm:
name: Build ARM64
runs-on: [self-hosted, linux, ARM64]
steps:

- name: Set up Go 1.14
uses: actions/setup-go@v2
with:
go-version: '1.14.3'
id: go

- name: Check out code into the Go module directory
uses: actions/checkout@v2

- name: Build
run: make docker all