update upstream cni to 1.5.1 #3065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orsenthil
reviewed
Oct 9, 2024
| @@ -279,7 +279,7 @@ docker-metrics-test: ## Run metrics helper unit test suite in a container. | |||
| make metrics-unit-test | |||
|
|
|||
| # Fetch the CNI plugins | |||
| plugins: FETCH_VERSION=1.4.0 | |||
There was a problem hiding this comment.
We have to look at the change log to see if these introduce any backwards incompatiblity changes. We had revert it back to 1.4.x sometime ago, if I remember correctly.
cc: @M00nF1sh do you recollect?
There was a problem hiding this comment.
There was a problem hiding this comment.
This update is fine. We aren't changing the CNI spec here.
|
I don't see any backwards incompatible changes listed in the releases
So, this upgrade looks good to me. |
orsenthil
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue does this PR fix?:
What does this PR do / Why do we need it?:
This is upgrading upstream CNI binary to v1.5.1.
Testing done on this change:
Will this PR introduce any new dependencies?:
Will this break upgrades or downgrades? Has updating a running cluster been tested?:
Does this change require updates to the CNI daemonset config files to work?:
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.