Skip to content

Commit

Permalink
Merge branch 'main' into colifran/alb-controller-versions
Browse files Browse the repository at this point in the history
  • Loading branch information
mergify[bot] authored May 15, 2023
2 parents 15c19ea + 25bd120 commit 038d80b
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 2 deletions.
4 changes: 4 additions & 0 deletions packages/@aws-cdk/aws-msk-alpha/lib/cluster-version.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,11 @@
*/
export class KafkaVersion {
/**
* **Deprecated by Amazon MSK. You can't create a Kafka cluster with a deprecated version.**
*
* Kafka version 1.1.1
*
* @deprecated use the latest runtime instead
*/
public static readonly V1_1_1 = KafkaVersion.of('1.1.1');

Expand Down
10 changes: 8 additions & 2 deletions packages/aws-cdk-lib/aws-route53/lib/record-set.ts
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,13 @@ export interface RecordSetOptions {
readonly zone: IHostedZone;

/**
* The domain name for this record.
* The subdomain name for this record. This should be relative to the zone root name.
*
* For example, if you want to create a record for acme.example.com, specify
* "acme".
*
* You can also specify the fully qualified domain name which terminates with a
* ".". For example, "acme.example.com.".
*
* @default zone root
*/
Expand Down Expand Up @@ -376,7 +382,7 @@ export class AaaaRecord extends RecordSet {
*/
export interface CnameRecordProps extends RecordSetOptions {
/**
* The domain name.
* The domain name of the target that this record should point to.
*/
readonly domainName: string;
}
Expand Down

0 comments on commit 038d80b

Please sign in to comment.