Fix integration test

aws · May 3, 2024 · e457942 · e457942
1 parent 98406ba
commit e457942
Show file tree

Hide file tree

Showing 6 changed files with 66 additions and 34 deletions.
diff --git a/...framework-integ/test/aws-ecr/test/integ.basic.js.snapshot/aws-ecr-integ-stack.assets.json b/...framework-integ/test/aws-ecr/test/integ.basic.js.snapshot/aws-ecr-integ-stack.assets.json
diff --git a/...amework-integ/test/aws-ecr/test/integ.basic.js.snapshot/aws-ecr-integ-stack.template.json b/...amework-integ/test/aws-ecr/test/integ.basic.js.snapshot/aws-ecr-integ-stack.template.json
@@ -103,11 +103,30 @@
         "Arn"
        ]
       },
-      "Id": "OnEventTargetLambda"
+      "Id": "Target0"
      }
     ]
    }
   },
+  "RepoOnEventOnEventTargetLambdaAllowEventRuleawsecrintegstackLambdaFunctionB6045AA7FBA3AA33": {
+   "Type": "AWS::Lambda::Permission",
+   "Properties": {
+    "Action": "lambda:InvokeFunction",
+    "FunctionName": {
+     "Fn::GetAtt": [
+      "LambdaFunctionBF21E41F",
+      "Arn"
+     ]
+    },
+    "Principal": "events.amazonaws.com",
+    "SourceArn": {
+     "Fn::GetAtt": [
+      "RepoOnEventOnEventTargetLambda2934FA99",
+      "Arn"
+     ]
+    }
+   }
+  },
   "LambdaFunctionServiceRoleC555A460": {
    "Type": "AWS::IAM::Role",
    "Properties": {

diff --git a/.../@aws-cdk-testing/framework-integ/test/aws-ecr/test/integ.basic.js.snapshot/manifest.json b/.../@aws-cdk-testing/framework-integ/test/aws-ecr/test/integ.basic.js.snapshot/manifest.json
diff --git a/...ages/@aws-cdk-testing/framework-integ/test/aws-ecr/test/integ.basic.js.snapshot/tree.json b/...ages/@aws-cdk-testing/framework-integ/test/aws-ecr/test/integ.basic.js.snapshot/tree.json
diff --git a/packages/@aws-cdk-testing/framework-integ/test/aws-ecr/test/integ.basic.ts b/packages/@aws-cdk-testing/framework-integ/test/aws-ecr/test/integ.basic.ts
@@ -3,6 +3,7 @@ import { IntegTest } from '@aws-cdk/integ-tests-alpha';
 import * as ecr from 'aws-cdk-lib/aws-ecr';
 import * as iam from 'aws-cdk-lib/aws-iam';
 import * as lambda from 'aws-cdk-lib/aws-lambda';
+import { LambdaFunction } from 'aws-cdk-lib/aws-events-targets';
 
 const app = new cdk.App();
 const stack = new cdk.Stack(app, 'aws-ecr-integ-stack');
@@ -30,15 +31,14 @@ new cdk.CfnOutput(stack, 'RepositoryURI', {
 });
 
 const repoOnEvent = new ecr.Repository(stack, 'RepoOnEvent');
-const lambdaFunction = new lambda.Function(stack, 'LambdaFunction', {
+const lambdaHandler = new lambda.Function(stack, 'LambdaFunction', {
   runtime: lambda.Runtime.PYTHON_3_12,
   code: lambda.Code.fromInline('# dummy func'),
   handler: 'index.handler',
 });
+
 repoOnEvent.onEvent('OnEventTargetLambda', {
-  target: {
-    bind: () => ({ arn: lambdaFunction.functionArn, id: 'OnEventTargetLambda' }),
-  },
+  target: new LambdaFunction(lambdaHandler),
 });
 
 new IntegTest(app, 'cdk-ecr-integ-test-basic', {

diff --git a/packages/aws-cdk-lib/aws-ecr/README.md b/packages/aws-cdk-lib/aws-ecr/README.md
@@ -217,15 +217,13 @@ You can publish repository events to a CloudWatch event rule with `onEvent`:
 import * as lambda from 'aws-cdk-lib/aws-lambda';
 
 const repo = new ecr.Repository(this, 'Repo');
-const lambdaFunction = new lambda.Function(this, 'LambdaFunction', {
+const lambdaHandler = new lambda.Function(this, 'LambdaFunction', {
   runtime: lambda.Runtime.PYTHON_3_12,
   code: lambda.Code.fromInline('# dummy func'),
   handler: 'index.handler',
 });
 
 repo.onEvent('OnEventTargetLambda', {
-  target: {
-    bind: () => ({ arn: lambdaFunction.functionArn, id: 'OnEventTargetLambda' }),
-  },
+  target: new LambdaFunction(lambdaHandler),
 });
 ```