Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(kinesisfirehose): L2 for CfnDeliveryStream #10810

Closed
2 tasks
Tracked by #7536
iliapolo opened this issue Oct 10, 2020 · 6 comments · Fixed by #15544
Closed
2 tasks
Tracked by #7536

(kinesisfirehose): L2 for CfnDeliveryStream #10810

iliapolo opened this issue Oct 10, 2020 · 6 comments · Fixed by #15544
Assignees
@otaviomacedo @BenChaimberg @madeline-k
Labels
@aws-cdk/aws-kinesisfirehose Related to Amazon Kinesis Data Firehose effort/large Large work item – several weeks of effort feature/new-construct A request for a new L2 construct feature-request A feature should be added or improved. p1
Milestone
[DevPreview] Kine...

Comments

@iliapolo
Copy link
Contributor

iliapolo commented Oct 10, 2020 •
edited
Loading

Use Case

Better ergonomics for using CfnDeliveryStream.

Part of #7536

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@iliapolo iliapolo added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 10, 2020
@github-actions github-actions bot added the @aws-cdk/aws-kinesisfirehose Related to Amazon Kinesis Data Firehose label Oct 10, 2020
@iliapolo iliapolo added effort/large Large work item – several weeks of effort p1 and removed needs-triage This issue or PR still needs to be triaged. labels Oct 10, 2020
@iliapolo iliapolo mentioned this issue Oct 10, 2020
Closed
@iliapolo
Copy link
Contributor Author

We should consider the scenario in this comment when we start working on this L2.

@mikelane
Copy link

I've started work on this.

@iliapolo
Copy link
Contributor Author

iliapolo commented Oct 16, 2020 •
edited
Loading

@mikelane Cool!

Do you maybe want to flush out the API before we get to the coding/reviewing part? Best option would be to create a theoretical README and submit that in a draft PR so we can talk about it.

@mikelane
Copy link

@mikelane Cool!

Do you maybe want to flush out the API before we get to the coding/reviewing part? Best option would be to create a theoretical README and submit that in a draft PR so we can talk about it.

I'd be happy to do that. I'll model it after other construct overview pages.

@ericzbeard ericzbeard added the feature/new-construct A request for a new L2 construct label Apr 2, 2021
This was referenced May 26, 2021
Closed
Closed
@BenChaimberg
Copy link
Contributor

@mikelane – the CDK team has started designing this construct and would love to see anything you have in progress to help guide our thinking!

@BenChaimberg BenChaimberg mentioned this issue Jun 1, 2021
Closed
@BenChaimberg BenChaimberg changed the title [aws-kinesisfirehose] L2 for CfnDeliveryStream (kinesisfirehose): L2 for CfnDeliveryStream Jun 23, 2021
@BenChaimberg BenChaimberg mentioned this issue Jul 12, 2021
Closed
8 tasks
This was referenced Jul 14, 2021
Closed
Merged
@mergify mergify bot closed this as completed in #15544 Jul 23, 2021
mergify bot pushed a commit that referenced this issue Jul 23, 2021
@madeline-k
feat(aws-kinesisfirehose): DeliveryStream API and basic S3 destination (
1b5d525 
#15544)

This PR implements the minimum DeliveryStream API and S3 destination.  

More features for DeliveryStream and the S3 destination will follow in future PRs. This work is being tracked in https://github.com/aws/aws-cdk/milestone/16 

For more context, see: #15505 and the RFC: aws/aws-cdk-rfcs#342 

closes #10810, #15499

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this issue Aug 3, 2021
@madeline-k @TikiTDO
feat(aws-kinesisfirehose): DeliveryStream API and basic S3 destination (
f553d60 
aws#15544)

This PR implements the minimum DeliveryStream API and S3 destination.  

More features for DeliveryStream and the S3 destination will follow in future PRs. This work is being tracked in https://github.com/aws/aws-cdk/milestone/16 

For more context, see: aws#15505 and the RFC: aws/aws-cdk-rfcs#342 

closes aws#10810, aws#15499

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this issue Aug 26, 2021
@madeline-k @hollanddd
feat(aws-kinesisfirehose): DeliveryStream API and basic S3 destination (
ab941c1 
aws#15544)

This PR implements the minimum DeliveryStream API and S3 destination.  

More features for DeliveryStream and the S3 destination will follow in future PRs. This work is being tracked in https://github.com/aws/aws-cdk/milestone/16 

For more context, see: aws#15505 and the RFC: aws/aws-cdk-rfcs#342 

closes aws#10810, aws#15499

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@otaviomacedo otaviomacedo

@BenChaimberg BenChaimberg

@madeline-k madeline-k

Labels
@aws-cdk/aws-kinesisfirehose Related to Amazon Kinesis Data Firehose effort/large Large work item – several weeks of effort feature/new-construct A request for a new L2 construct feature-request A feature should be added or improved. p1
Projects
None yet
Milestone
[DevPreview] Kinesis Data Firehose
6 participants
@otaviomacedo @ericzbeard @iliapolo @BenChaimberg @mikelane @madeline-k