Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[codedeploy] Add ECSApplication types #2056

Closed
allisaurus opened this issue Mar 19, 2019 · 17 comments
Closed

[codedeploy] Add ECSApplication types #2056

allisaurus opened this issue Mar 19, 2019 · 17 comments
Assignees
Labels
@aws-cdk/aws-codedeploy Related to AWS CodeDeploy feature-request A feature should be added or improved. needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed.

Comments

@allisaurus
Copy link
Contributor

Currently, server and lambda application constructs are available, however ECS is also a supported application type. Adding this construct (and it's child constructs) will facilitate setup of deployment actions to ECS, including Blue/Green deployments (#1559).

@SoManyHs SoManyHs added @aws-cdk/aws-codedeploy Related to AWS CodeDeploy gap labels Mar 19, 2019
@skinny85
Copy link
Contributor

Unfortunately, this is not modeled in CloudFormation yet :(

@mmoulton
Copy link

@skinny85 can you clarify what is not yet supported by CF? Is it that AWS::CodeDeploy::Application does not yet accept a computePlatform of ECS despite the docs alluding to it?

Also, do you know if this is the responsibility of the containers team or the CF team to implement the missing support?

@ghost
Copy link

ghost commented Mar 26, 2019

this has been talked about for months now ... trying to get the ECS / CF team to implement this is proving to be taxing.

@skinny85
Copy link
Contributor

@mmoulton yes, it's present in the API for CodeDeploy, and that's where the documentation points to, but still not in CloudFormation unfortunately.

@sarojgharat
Copy link

Yes. Need the cloudformation support. Waiting since a long time

@mmoulton
Copy link

Thanks all. @skinny85 do you happen to know if it's the codedeploy team, the containers team, or the larger CF team that needs to do the implementation? Since the containers team has already integrated with codedeploy, it makes me think that the CodeDeploy CF resources are where the work is still left to be done, but I'm not sure. It would be helpful to know when I'm asking my reps.

@ChrisLahaye
Copy link

How do you guys tackle deployments to ECS? Creating the pipeline and codedeploy project manually?

@skinny85
Copy link
Contributor

We use the ECS deploy Action that does rolling (instead of blue-green) deployments.

@ChrisLahaye
Copy link

ChrisLahaye commented Apr 24, 2019

We use the ECS deploy Action that does rolling (instead of blue-green) deployments.

Thanks for your reply. How do you use it? Seems like that action isn't part of the 0.28 release on npmjs

@skinny85
Copy link
Contributor

Ah yes, my apologies. It's still very fresh. It will be present in our next release, 0.29.0.

@skinny85 skinny85 added the pr/blocked This PR cannot be merged or reviewed, because it is blocked for some reason. label Aug 2, 2019
@skinny85
Copy link
Contributor

skinny85 commented Aug 2, 2019

Here's the ticket tracking this functionality in the newly open-sourced CloudFormation public roadmap: aws-cloudformation/cloudformation-coverage-roadmap#37

Feel free to pile on with +1 in that issue to get it prioritized!

@skinny85 skinny85 self-assigned this Aug 12, 2019
@strax
Copy link
Contributor

strax commented Aug 12, 2019

Even if blue/green deployments might not be supported via CloudFormation, it seems to be possible to define an AWS::CodeDeploy::Application resource with ECS as the compute platform: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-codedeploy-application.html#aws-resource-codedeploy-application-properties; it also worked when I created one through CF.

I guess it'd be possible use this in combination with a custom resource that provisions a blue/green deployment group on the application.

@SomayaB SomayaB added needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. and removed pr/blocked This PR cannot be merged or reviewed, because it is blocked for some reason. labels Oct 29, 2019
@SomayaB SomayaB added feature-request A feature should be added or improved. and removed gap labels Nov 11, 2019
@gbooth27
Copy link

any news on this?

@clareliguori
Copy link
Member

EcsApplication construct is done:
https://docs.aws.amazon.com/cdk/api/latest/docs/@aws-cdk_aws-codedeploy.EcsApplication.html

There is also an EcsDeploymentGroup class, but it is only for importing an existing CodeDeploy deployment group created outside of CloudFormation:
https://docs.aws.amazon.com/cdk/api/latest/docs/@aws-cdk_aws-codedeploy.EcsDeploymentGroup.html

And there is a CodePipeline action for ECS-CodeDeploy deployments:
https://docs.aws.amazon.com/cdk/api/latest/docs/@aws-cdk_aws-codepipeline-actions.CodeDeployEcsDeployAction.html

@jewelsjacobs
Copy link

Looks like CF just added support for a CODE_DEPLOY AWS::ECS::Service DeploymentController Type:
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ecs-service-deploymentcontroller.html

@tbrand
Copy link

tbrand commented Feb 20, 2020

Any updates for this?

@skinny85
Copy link
Contributor

Yes, this was done in #4600.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-codedeploy Related to AWS CodeDeploy feature-request A feature should be added or improved. needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed.
Projects
None yet
Development

No branches or pull requests