Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(codedeploy): Model ECS deployment resources and pipeline action #4600

Merged
merged 5 commits into from
Oct 25, 2019
Merged

feat(codedeploy): Model ECS deployment resources and pipeline action #4600

merged 5 commits into from
Oct 25, 2019

Conversation

clareliguori
Copy link
Member

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mergify
Copy link
Contributor

mergify bot commented Oct 21, 2019

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

  • PR title type(scope): text
    • type: fix, feat, refactor go into CHANGELOG, chore is hidden
    • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
    • text: use all lower-case, do not end with a period, do not include issue refs
  • PR Description
    • Rationale: describe rationale of change and approach taken
    • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
    • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Testing
    • Unit test added. Prefer to add a new test rather than modify existing tests
    • CLI or init templates change? Re-run/add CLI integration tests
  • Documentation
    • README: update module README to describe new features
    • API docs: public APIs must be documented. Copy from official AWS docs when possible
    • Design: for significant features, follow design process

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@clareliguori clareliguori force-pushed the ecs-codedeploy-action branch from a9c168c to 9bef4fb Compare October 21, 2019 05:11
@clareliguori
Copy link
Member Author

FYI @SoManyHs

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

skinny85
skinny85 reviewed Oct 24, 2019
View reviewed changes
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the contribution @clareliguori ! I've only taken a quick glance so far, but from what I've seen this might be one of the highest quality PRs outside our core team that I had the pleasure of reviewing.

I'll take a deeper look tomorrow, but for now I had one question.

packages/@aws-cdk/aws-codedeploy/lib/ecs/deployment-group.ts Show resolved Hide resolved
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

skinny85
skinny85 reviewed Oct 24, 2019
View reviewed changes
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic contribution. I have some comments, but nothing major.

Thanks so much for submitting this!

packages/@aws-cdk/aws-codedeploy/lib/ecs/application.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-codedeploy/lib/ecs/deployment-config.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-codedeploy/lib/ecs/deployment-config.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-codedeploy/lib/ecs/deployment-group.ts Show resolved Hide resolved
packages/@aws-cdk/aws-codedeploy/test/ecs/test.application.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-codepipeline-actions/lib/codedeploy/ecs-deploy-action.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-codepipeline-actions/lib/codedeploy/ecs-deploy-action.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-codepipeline-actions/lib/codedeploy/ecs-deploy-action.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-codepipeline-actions/lib/codedeploy/ecs-deploy-action.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-codepipeline-actions/test/integ.pipeline-code-deploy-ecs.ts

const application = codedeploy.EcsApplication.fromEcsApplicationName(stack, 'CodeDeployApplication', 'IntegTestDeployApp');

const deploymentGroup = codedeploy.EcsDeploymentGroup.fromEcsDeploymentGroupAttributes(stack, 'CodeDeployGroup', {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this deploy without having these ECS CodeDeploy Applications and DeploymentGroup in the account (called 'IntegTestDeployApp' and 'IntegTestDeploymentGroup', respectively)? Because if this doesn't, that's kind of a problem when updating these tests.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I can successfully do cdk deploy --app 'node integ.pipeline-code-deploy-ecs.js'

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

skinny85
skinny85 approved these changes Oct 25, 2019
View reviewed changes
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mergify
Copy link
Contributor

mergify bot commented Oct 25, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit ed639ca into aws:master Oct 25, 2019
@skinny85 skinny85 mentioned this pull request Feb 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skinny85 skinny85 skinny85 approved these changes

Assignees

@skinny85 skinny85

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clareliguori @aws-cdk-automation @skinny85