-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(stepfunctions-tasks): support parameters in StepFunctionsInvokeActivity #21020
Comments
There is always a There is no regression here. Repurposing this issue as a feature request. |
There is a dramatic difference between State and Task in V1: And it is not a feature. You should being use base interface for all things derived from task to not miss such things and still leave ability to interact with generated json for tasks as well rather creating huge amount of specific tasks with no proper class hierarchy. |
You can always extend import { Stack, StackProps } from 'aws-cdk-lib';
import { Construct } from 'constructs';
import * as iam from 'aws-cdk-lib/aws-iam';
import * as sfn from 'aws-cdk-lib/aws-stepfunctions';
export class CustomStack extends Stack {
constructor(scope: Construct, id: string, props?: StackProps) {
super(scope, id, props);
const task = new CustomTask(this, 'id', {});
task.addCatch(new sfn.Fail(this, 'fail'));
const machine = new sfn.StateMachine(this, 'machine', {
definition: task.next(new sfn.Succeed(this, 'success')),
});
}
}
interface CustomProps extends sfn.TaskStateBaseProps {}
class CustomTask extends sfn.TaskStateBase {
protected readonly taskMetrics?: sfn.TaskMetricsConfig;
protected readonly taskPolicies?: iam.PolicyStatement[];
constructor(scope: Construct, id: string, private readonly props: CustomProps) {
super(scope, id, props);
}
protected _renderTask(): any {
return {};
}
} |
…ctivity (#21077) Fixes #21020 This PR adds the parameters to the StepFunctionsInvokeActivity class. ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
Describe the bug
You already closed same ticket in CDK1 and probably because of this ignorance to customer pain never added it to v2.
Here is a ticket: #1480
It is not even feature request - it is already a bug in cdk 2 as with dropping arbitrary Task class you actually made impossible to have this parameter specified for Activities.
I know that this ticket will be auto closed as many others as usual.
But this is a nonsense.
Or at least spent some of your time to provide workaround if supporting something what here for years is too hard for the CDK team.
Expected Behavior
software.amazon.awscdk.services.stepfunctions.tasks.StepFunctionsInvokeActivity should have parameters.
Current Behavior
software.amazon.awscdk.services.stepfunctions.tasks.StepFunctionsInvokeActivity does not have parameters
Task is deprecated. You make things impossible for migration.
Reproduction Steps
It is not even required to run anything.
Just go and try to use parameters for software.amazon.awscdk.services.stepfunctions.tasks.StepFunctionsInvokeActivity
Possible Solution
Will really appreciate if you provide any.
Additional Information/Context
No response
CDK CLI Version
2
Framework Version
No response
Node.js Version
16
OS
linux
Language
Typescript
Language Version
No response
Other information
No response
The text was updated successfully, but these errors were encountered: