-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(integ-tests): awsApiCall Response object is too long
#22059
Comments
I'm working on an update where the assertions are done in the same handler instead of passing the data to another resource. Hopefully that will fix this issue. |
@corymhall I saw that #22238 was merged, but it didn't seem to fix the issue. Perhaps an easy way to fix the issue would be to use the bootstrap assets bucket as a proxy.
|
Currently
In order to accommodate the second we first flatten the results (if we need to) and then perform assertions and then return everything. What I want to do is change this around a little. We should perform assertions on the response (without flattening) and then if we also need to return a value we can flatten if needed and then only return the value that is needed. |
fixes #22059 follows precedent set in #14041 also added filtering to assertAtPath to reduce duplication and reduce the chance of hitting the error for developers using the library also added test for assertAtPath ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
fixes aws#22059 follows precedent set in aws#14041 also added filtering to assertAtPath to reduce duplication and reduce the chance of hitting the error for developers using the library also added test for assertAtPath ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
fixes aws#22059 follows precedent set in aws#14041 also added filtering to assertAtPath to reduce duplication and reduce the chance of hitting the error for developers using the library also added test for assertAtPath ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…#22063) Closes #22009 Currently waiting on #22055 and #22059 for the assertions in the integration test to successfully run ---- ### All Submissions: * [X] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [X] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [X] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
fixes aws#22059 follows precedent set in aws#14041 also added filtering to assertAtPath to reduce duplication and reduce the chance of hitting the error for developers using the library also added test for assertAtPath ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Describe the bug
When using
assertions.awsApiCall
my response object was too large and caused the integration test stack to fail deployment.Expected Behavior
I can limit the
outputPath
of the api call like done here ##2825Current Behavior
I can't limit the output and get around the 4k response limit for CloudFormation
Reproduction Steps
integ.reproduction.ts
Possible Solution
Implement an
outputPath
feature like done here ##2825 to limit the response objectAdditional Information/Context
No response
CDK CLI Version
2.41.0
Framework Version
No response
Node.js Version
v16.16.0
OS
OsX
Language
Typescript
Language Version
No response
Other information
No response
The text was updated successfully, but these errors were encountered: