Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emr-create-cluster: uses EMR V1 policies instead of V2 #23915

Closed
davidjgolding opened this issue Jan 30, 2023 · 3 comments · Fixed by #23985
Closed

emr-create-cluster: uses EMR V1 policies instead of V2 #23915

davidjgolding opened this issue Jan 30, 2023 · 3 comments · Fixed by #23985
Labels
@aws-cdk/aws-emr Related to Amazon EMR bug This issue is a bug. effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md p2

Comments

@davidjgolding
Copy link

Describe the bug

AWS documentation states that V1 policies are on the deprecation path, however, they are still used within CDK. For example, by default, the service role created uses AmazonElasticMapReduceRole instead of AmazonEMRServicePolicy_v2. Consequently, I have received warnings that these policies are going to be deprecated and that I should update them.

Expected Behavior

V2 policies should be used as documented here.

Current Behavior

V1 policies are used.

Reproduction Steps

N/A

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.51.0

Framework Version

No response

Node.js Version

v16.19.0

OS

macOS

Language

Typescript

Language Version

No response

Other information

No response
@davidjgolding davidjgolding added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jan 30, 2023
@github-actions github-actions bot added the @aws-cdk/aws-emr Related to Amazon EMR label Jan 30, 2023
@pahud pahud added effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Jan 31, 2023
@pahud
Copy link
Contributor

pahud commented Jan 31, 2023

Thank you and agree. Are you interested to submit a PR for this?

@davidjgolding
Copy link
Author

Hey @pahud - I don't currently have the capacity to do this so it would be great if you could help!

@pahud pahud added p2 good first issue Related to contributions. See CONTRIBUTING.md labels Jan 31, 2023
@lpizzinidev lpizzinidev mentioned this issue Feb 3, 2023
Merged
lpizzinidev added a commit to lpizzinidev/aws-cdk that referenced this issue Feb 4, 2023
@lpizzinidev
Merge branch 'main' into awsgh-23915
0aa6af8
lpizzinidev added a commit to lpizzinidev/aws-cdk that referenced this issue Feb 13, 2023
@lpizzinidev
Merge branch 'main' into awsgh-23915
6b935c4
mergify bot added a commit to lpizzinidev/aws-cdk that referenced this issue Feb 27, 2023
@mergify
Merge branch 'main' into awsgh-23915
8983ad8
lpizzinidev added a commit to lpizzinidev/aws-cdk that referenced this issue Mar 8, 2023
@lpizzinidev
Merge branch 'main' into awsgh-23915
b455ed0
lpizzinidev added a commit to lpizzinidev/aws-cdk that referenced this issue Mar 8, 2023
@lpizzinidev
Merge branch 'main' into awsgh-23915
92d3efc
lpizzinidev added a commit to lpizzinidev/aws-cdk that referenced this issue Mar 12, 2023
@lpizzinidev
Merged main branch into awsgh-23915
a40c7f1
MrArnoldPalmer added a commit to lpizzinidev/aws-cdk that referenced this issue Mar 23, 2023
@MrArnoldPalmer
Merge branch 'main' into awsgh-23915
92ff8e4
mergify bot added a commit to lpizzinidev/aws-cdk that referenced this issue Mar 24, 2023
@mergify
Merge branch 'main' into awsgh-23915
de3479b
@mergify mergify bot closed this as completed in #23985 Mar 24, 2023
mergify bot pushed a commit that referenced this issue Mar 24, 2023
@lpizzinidev
fix(stepfunctions-tasks): updated EMR service role to use `AmazonEMRS…
f3fd183 
…ervicePolicy_v2` (under feature flag) (#23985)

Closes #23915 

**Summary**
Changed EMR used policies from `AmazonElasticMapReduceRole` to `AmazonEMRServicePolicy_v2` as by [documentation](https://docs.aws.amazon.com/emr/latest/ManagementGuide/emr-managed-iam-policies.html).

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

homakk pushed a commit to homakk/aws-cdk that referenced this issue Mar 28, 2023
@lpizzinidev @homakk
fix(stepfunctions-tasks): updated EMR service role to use `AmazonEMRS…
fe8fc75 
…ervicePolicy_v2` (under feature flag) (aws#23985)

Closes aws#23915 

**Summary**
Changed EMR used policies from `AmazonElasticMapReduceRole` to `AmazonEMRServicePolicy_v2` as by [documentation](https://docs.aws.amazon.com/emr/latest/ManagementGuide/emr-managed-iam-policies.html).

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-emr Related to Amazon EMR bug This issue is a bug. effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md p2
Projects
None yet
Milestone
No milestone
2 participants
@pahud @davidjgolding