-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws-eks: KubectlProvider fails to create/update in govcloud #24808
Labels
@aws-cdk/aws-eks
Related to Amazon Elastic Kubernetes Service
bug
This issue is a bug.
effort/medium
Medium work item – several days of effort
p2
Comments
Thank you. I am working on this issue at #25215. Will add gov cloud in the exclusion list. |
This was referenced Apr 18, 2023
mergify bot
pushed a commit
that referenced
this issue
Apr 21, 2023
…Cloud regions (#25215) Reopening this PR because #25170 was closed by accident. As ECR Public is not available in China regions and GovCloud, `AmazonElasticContainerRegistryPublicReadOnly` IAM managed policy would not be available in those affected regions and should not be attached to the role. This PR implements a CfnCondition to determine if ECR public is available based on `Aws.Partition` of the deploying region and conditionally attach `AmazonElasticContainerRegistryPublicReadOnly` to the kubectl-provider handler role. This PR has been tested in the following regions: - [x] *cn-north-1 - [x] *cn-northwest-1 - [x] us-east-1 * I can confirm the role is created correctly in cn regions but due to - #24358 - #24696 The cluster and nodegroup are still failing to create in CN. Closes #24743 #24808 #25178
closed by #25215 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@aws-cdk/aws-eks
Related to Amazon Elastic Kubernetes Service
bug
This issue is a bug.
effort/medium
Medium work item – several days of effort
p2
Describe the bug
In govcloud (aws-us-gov partition), "Amazon ECR public registries aren't supported." https://docs.aws.amazon.com/govcloud-us/latest/UserGuide/govcloud-ecr.html
The managed policy "AmazonElasticContainerRegistryPublicReadOnly" does not exist there.
#24104 added this managed policy "AmazonElasticContainerRegistryPublicReadOnly" and now KubectlProvider HandlerServiceRole fails to create/update.
Expected Behavior
KubectlProvider HandlerServiceRole successfully creates/updates in govcloud same as in other AWS partitions
Current Behavior
KubectlProvider HandlerServiceRole fails to create/update in govcloud
Reproduction Steps
Create a 1.25 EKS cluster in govcloud*
Possible Solution
Wrap this:
in a partition check
Additional Information/Context
No response
CDK CLI Version
2.27.0 (build 8e89048)Framework Version
Node.js Version
v18.14.0
OS
linux
Language
Typescript
Language Version
No response
Other information
No response
The text was updated successfully, but these errors were encountered: