aws_batch_alpha: JobQueue uses wrong id for underlying CfnJobQueue

[diego-santacruz]

Describe the bug

With the new API in aws_batch_alpha the node.defaultChild property no longer returns the underlying CfnJobQueue.

I tracked this to the fact that instead of using 'Resource' as the id for the CfnJobQueue created in

aws-cdk/packages/@aws-cdk/aws-batch-alpha/lib/job-queue.ts

Line 181 in 046d0fc

const resource = new CfnJobQueue(this, id, {

the id of the parent JobQueue is used. Before rewriting JobQueue for the new API it was 'Resource'.

This also has the effect that the logical ID of a JobQueue changed with the new API, although there was no reason for it.

Expected Behavior

JobQueue's node.defaultChild property returns the underlying CfnJobQueue.

Current Behavior

JobQueue's node.defaultChild property returns undefined.

Reproduction Steps

Trivial

Possible Solution

Use the usual 'Resource' string as the id for the CfnJobQueue.

Additional Information/Context

No response

CDK CLI Version

2.76

Framework Version

2.76

Node.js Version

v16.18.1

OS

Linux

Language

Typescript

Language Version

4.9.5

Other information

No response

[peterwoodworth]

Makes sense, thanks for reporting. @comcalvi do we want to change the id to Resource, or should we manually set the CfnJobQueue as the default child of this construct?

[comcalvi]

definitely change the id to Resource

[daschaa]

Should this be feature-flagged?

[diego-santacruz]

My opinion is that given that this a change recently introduced (2.74) in an experimental package, and that apparently there are not many users of this new package version given the number of bugs that I've found for ECS on EC2 and that had not been reported yet I think not many people will care or notice the change if released soon. So I would not put it behind a feature flag.

[peterwoodworth]

I don't think it needs to be behind a feature flag simply because this is not a stable package yet

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.