Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(stepfunctions-tasks): InputMode for SageMaker does not support FastFile #26653

Closed
2 tasks
straygar opened this issue Aug 7, 2023 · 4 comments · Fixed by #26675
Closed
2 tasks

(stepfunctions-tasks): InputMode for SageMaker does not support FastFile #26653

straygar opened this issue Aug 7, 2023 · 4 comments · Fixed by #26675
Labels
@aws-cdk/aws-stepfunctions-tasks effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2

Comments

@straygar
Copy link

straygar commented Aug 7, 2023

Describe the feature

Use Case

The feature can lead to performance gains when your training job works on a subset of the data that lives under the prefix, with little implementation effort.

Proposed Solution

Add 'FastFile' to the enum

Other Information

I haven't checked whether the SFN integration with the SageMaker API call supports this or throws an error, but other API fields are fully supported now so I don't see why not.

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.90.0

Environment details (OS name and version, etc.)

Mac OS
@straygar straygar added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 7, 2023
@peterwoodworth peterwoodworth added good first issue Related to contributions. See CONTRIBUTING.md p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Aug 7, 2023
@peterwoodworth
Copy link
Contributor

Yes, makes sense 👍🏻 Check out our contributing guide if you're interested in helping out with this

@tmyoda
Copy link
Contributor

tmyoda commented Aug 8, 2023

It seems like no one is working on this issue, I will work on this

@tmyoda tmyoda mentioned this issue Aug 9, 2023
Merged
@mergify mergify bot closed this as completed in #26675 Aug 23, 2023
mergify bot pushed a commit that referenced this issue Aug 23, 2023
@tmyoda
feat(stepfunctions-tasks): FastFile mode for SageMaker Training Job (#…
5fef403 
…26675)

According to the AWS documentation, the TrainingInputMode for a SageMaker Training Job can be one of the following: `Pipe | File | FastFile`

https://docs.aws.amazon.com/sagemaker/latest/APIReference/API_Channel.html#sagemaker-Type-Channel-InputMode

https://docs.aws.amazon.com/sagemaker/latest/APIReference/API_AlgorithmSpecification.html#API_AlgorithmSpecification_Contents


I have just added `FastFile` below to align with the official documentation.
https://github.com/aws/aws-cdk/blob/v2.90.0/packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/sagemaker/base-types.ts#L458

Closes #26653.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot mentioned this issue Sep 1, 2023
Closed
@straygar
Copy link
Author

@tmyoda Thanks for picking this up, Tomoya! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-stepfunctions-tasks effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(stepfunctions-tasks): FastFile mode for SageMaker Training Job tmyoda/aws-cdk
3 participants
@straygar @tmyoda @peterwoodworth