-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws-stepfunctions: comment field appears not supported #27005
Comments
@mrgrain I'll take this. It's there but not implemented. |
I linked the wrong type of comment jfyi. That is working as expected. But my PR adds the requested comment. |
Thanks @berenddeboer for reaching out with this request. Thanks @msambol for submitting a PR. Appreciate your contribution. |
Currently you can comment on a `Choice` state. This adds the ability to comment on a when condition. <img width="437" alt="Screenshot 2023-09-05 at 7 47 35 AM" src="https://github.com/aws/aws-cdk/assets/3310356/4cb92427-c16c-4994-9e86-0384c4c2b075"> <img width="473" alt="Screenshot 2023-09-05 at 7 54 29 AM" src="https://github.com/aws/aws-cdk/assets/3310356/4dc1857e-5515-4510-8fde-a5eb8bc93afe"> Closes #27005. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
Currently you can comment on a `Choice` state. This adds the ability to comment on a when condition. <img width="437" alt="Screenshot 2023-09-05 at 7 47 35 AM" src="https://github.com/aws/aws-cdk/assets/3310356/4cb92427-c16c-4994-9e86-0384c4c2b075"> <img width="473" alt="Screenshot 2023-09-05 at 7 54 29 AM" src="https://github.com/aws/aws-cdk/assets/3310356/4dc1857e-5515-4510-8fde-a5eb8bc93afe"> Closes #27005. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Describe the feature
When editing a state machine via the AWS Console, I could provide a comment for a choice rule. It suggest my state language will look like this:
This "yes" comment gets nicely displayed in the graph. However, I could not see a way to generate this comment field withi CDK. Is that correct?
Are there any plans to introduce that? Really great for more complex flows.
Unfortunately this comment is only visible in the editor, not in the "Definition" tab.
Use Case
Improve output of state machine graph.
Proposed Solution
Add a property or optional input to
sfn.Condition.isBoolean()
.Other Information
No response
Acknowledgements
CDK version used
2.91.0
Environment details (OS name and version, etc.)
Mac x86_64, Darwin kernel 22.6.0
The text was updated successfully, but these errors were encountered: