Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-elasticloadbalancingv2: SslPolicy enum doesn't include FIPS policies #28455

Closed
nwesoccer opened this issue Dec 21, 2023 · 2 comments · Fixed by #28479
Closed

aws-elasticloadbalancingv2: SslPolicy enum doesn't include FIPS policies #28455

nwesoccer opened this issue Dec 21, 2023 · 2 comments · Fixed by #28479
Labels
@aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 bug This issue is a bug. effort/small Small work item – less than a day of effort p2

Comments

@nwesoccer
Copy link

Describe the bug

The SslPolicy enum does not include the FIPS Policies that were announce in November (https://docs.aws.amazon.com/elasticloadbalancing/latest/application/create-https-listener.html#fips-security-policies).

Expected Behavior

All Policies would be present in the SslPolicy enum, or there would be an option to use our own as a string.

Current Behavior

No FIPS policies can be selected/used.

Reproduction Steps

Create an ALB Listener. During the create, use attempt to set the sslPolicy property to SslPolicy.(value that represents ELBSecurityPolicy-TLS13-1-2-Ext0-FIPS-2023-04 policy).

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.114.1

Framework Version

No response

Node.js Version

18

OS

Mac

Language

TypeScript

Language Version

No response

Other information

No response
@nwesoccer nwesoccer added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Dec 21, 2023
@github-actions github-actions bot added the @aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 label Dec 21, 2023
@pahud pahud self-assigned this Dec 22, 2023
@pahud
Copy link
Contributor

pahud commented Dec 22, 2023

Looks like we can simply add it into the enum

aws-cdk/packages/aws-cdk-lib/aws-elasticloadbalancingv2/lib/shared/enums.ts

Line 99 in cd54c42

export enum SslPolicy {

Are you interested to submit a PR for that?

@pahud pahud added p2 effort/small Small work item – less than a day of effort labels Dec 22, 2023
@pahud pahud removed their assignment Dec 22, 2023
@pahud pahud removed the needs-triage This issue or PR still needs to be triaged. label Dec 22, 2023
@badmintoncryer badmintoncryer mentioned this issue Dec 23, 2023
Merged
@mergify mergify bot closed this as completed in #28479 Dec 23, 2023
mergify bot pushed a commit that referenced this issue Dec 23, 2023
@badmintoncryer
feat(elasticloadbalancingv2): FIPS compliant SSL policy to ALB (#28479)
7bb72e1 
This Pull Request introduces a set of new FIPS-compliant SSL policies for the Application Load Balancer (ALB) in AWS Elastic Load Balancing (ELB). These policies enhance the security of ALB by providing options that are compliant with the Federal Information Processing Standards (FIPS).

Closes #28455 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot mentioned this issue Jan 1, 2024
Closed
paulhcsun pushed a commit to paulhcsun/aws-cdk that referenced this issue Jan 5, 2024
@badmintoncryer @paulhcsun
feat(elasticloadbalancingv2): FIPS compliant SSL policy to ALB (aws#2…
0512554 
…8479)

This Pull Request introduces a set of new FIPS-compliant SSL policies for the Application Load Balancer (ALB) in AWS Elastic Load Balancing (ELB). These policies enhance the security of ALB by providing options that are compliant with the Federal Information Processing Standards (FIPS).

Closes aws#28455 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 bug This issue is a bug. effort/small Small work item – less than a day of effort p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(elasticloadbalancingv2): FIPS compliant SSL policy to ALB badmintoncryer/aws-cdk
2 participants
@pahud @nwesoccer