Allow overriding default removal policy

[eladb]

Note: for support questions, please first reference our documentation, then use Stackoverflow. This repository's issues are intended for feature requests and bug reports.

• I'm submitting a ...

  • 🪲 bug report
  • 🚀 feature request
  • 📚 construct library gap
  • ☎️ security issue or vulnerability => Please see policy
  • ❓ support request => Please see note at the top of this template.

• What is the current behavior?
  If the current behavior is a 🪲bug🪲: Please provide the steps to reproduce

The default removal policy for stateful resources is to retain the resource. This means that, for example, buckets will never be deleted.

• What is the expected behavior (or behavior of feature suggested)?

It would be nice if it was possible to override this default behavior at the stack level and/or at the toolkit level. For example, I'd argue that development stacks would want the default to be "delete".

• What is the motivation / use case for changing the behavior or adding this feature?

Reports from users that they don't understand why the CDK leaves all this garbage in their accounts.

[nmussy]

This feature would be greatly appreciated.

One way I could see it is resources should be ephemeral during the stack development and retained once in production. Maybe it could be tied to the NODE_ENV variable, if that's not too much of a dark pattern. Likewise, a --development and --production CLI option.

Then again, just an explicit --discard and --retain option might be more clear.

There's also the issue of the Snapshot-able resources, listed at the end of this page. Should there also be a --retain-snapshot option, which snapshots the resources that support it, and keep the rest, and an equivalent --discard-snapshot?

[eladb]

Related to aws/aws-cdk-rfcs#23

[Dzhuneyt]

I was so frustrated by the leftover S3 buckets that are hard to delete, once they accumulate in large numbers inside the AWS account, I resorted to creating my own utility to purge orphan S3 buckets (ones not attached to any CloudFormation stacks):
https://github.com/Dzhuneyt/nuke-orphan-buckets

It would have been nice if CDK deleted those by default.