Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sets removal policy on S3 and DynamoDB to DESTROY #100

Merged
merged 1 commit into from
Aug 8, 2019

Conversation

hellnation
Copy link
Contributor

@hellnation hellnation commented Aug 8, 2019

Issue #, if available:
#99

Description of changes:
Changes the behaviour of examples that create S3 Buckets and DynamoDB Tables such that these resources are deleted by cdk destroy. Explains the behaviour in comments

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@eladb
Copy link

eladb commented Aug 8, 2019

We should use aws/aws-cdk#2973 once it's available.

@eladb eladb merged commit e8d9b04 into aws-samples:master Aug 8, 2019
its-mirus-lu pushed a commit to its-mirus-lu/aws-cdk-examples that referenced this pull request Mar 26, 2022
…tacks

sets removal policy on S3 and DynamoDB to DESTROY
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants