-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(cli): Stack undefined
in cdk deploy
output
#31685
Comments
Experiencing same. When I use |
@meve / @akhilesh-akza Could you please test with Thanks, |
@ashishdhingra I'm pretty sure this issue is still present in v2.161.1. I think it can be solved by just fixing that condition; it is only hit in the deploy path if I see it correctly:
Thank you, Joost |
The specific issue I mentioned is fixed in latest version. It seems default initialised project has frozen version in ✨ Synthesis time: 8.36s
Stack undefined But this still exists. Nothing major but better to clean it up so as to not cause confusion that somewhere name is not being read. |
Comments on closed issues and PRs are hard for our team to see. |
1 similar comment
Comments on closed issues and PRs are hard for our team to see. |
If a user is deploying with `--no-rollback`, and the stack contains replacements (or the `--no-rollback` flag is dropped), then a rollback needs to be performed before a regular deployment can happen again. In this PR, we add a prompt where we ask the user to confirm that they are okay with performing a rollback and then a normal deployment. The way this works is that `deployStack` detects a disallowed combination (replacement and no-rollback, or being in a stuck state and not being called with no-rollback), and returns a special status code. The driver of the calls, `CdkToolkit`, will see those special return codes, prompt the user, and retry. Also get rid of a stray `Stack undefined` that gets printed to the console. Closes aws#30546, Closes aws#31685 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Describe the bug
Running
cdk deploy
using the cli seems to return 'Stack undefined' in some cases.Regression Issue
Last Known Working CDK Version
v2.160.0
Expected Behavior
To either show:
Or nothing.
Current Behavior
I receive output like this:
Reproduction Steps
Run
.
Possible Solution
I included a PR. The cause I suppose is related to bcf9209#diff-c7b9751a4ca56b6ee26510c9f650f6d5328f5be39071c93165aadbc138496eddR130. To resolve this, I just copied the condition found on line 42 of the same file, as it checks if
stackName
is defined or not. The comment on the line above seems to be identical as well.Additional Information/Context
No response
CDK CLI Version
2.161.1 (build 0a606c9)
Framework Version
No response
Node.js Version
v18.20.4
OS
macOS 14.6.1 (23G93)
Language
TypeScript
Language Version
No response
Other information
No response
The text was updated successfully, but these errors were encountered: