aws-codebuild: CodeBuild new environment types missing from CDK #32728
Labels
@aws-cdk/aws-codebuild
Related to AWS CodeBuild
feature-request
A feature should be added or improved.
needs-triage
This issue or PR still needs to be triaged.
Comments
awszhen
added
feature-request
1 task
mergify bot
pushed a commit
that referenced
this issue
Jan 4, 2025
### Issue # (if applicable) Closes #32728. ### Reason for this change Recently, CodeBuild released a new set of environment types which can be found [here](https://docs.aws.amazon.com/codebuild/latest/APIReference/API_CreateFleet.html#CodeBuild-CreateFleet-request-environmentType): `LINUX_EC2`, `ARM_EC2` and `WINDOWS_EC2`. The CDK needs to be extended to support these new environment types. ### Description of changes Added `LINUX_EC2`, `ARM_EC2` and `WINDOWS_EC2` values to [EnvironmentType](https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-codebuild/lib/environment-type.ts). ### Description of how you validated changes Tests has been added. I ensured that the CDK was able to build, and that the output CloudFormation stack had the correct resources. ### Checklist - [X] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
Comments on closed issues and PRs are hard for our team to see. |
iankhou
pushed a commit
that referenced
this issue
Jan 13, 2025
### Issue # (if applicable) Closes #32728. ### Reason for this change Recently, CodeBuild released a new set of environment types which can be found [here](https://docs.aws.amazon.com/codebuild/latest/APIReference/API_CreateFleet.html#CodeBuild-CreateFleet-request-environmentType): `LINUX_EC2`, `ARM_EC2` and `WINDOWS_EC2`. The CDK needs to be extended to support these new environment types. ### Description of changes Added `LINUX_EC2`, `ARM_EC2` and `WINDOWS_EC2` values to [EnvironmentType](https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-codebuild/lib/environment-type.ts). ### Description of how you validated changes Tests has been added. I ensured that the CDK was able to build, and that the output CloudFormation stack had the correct resources. ### Checklist - [X] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Describe the feature
Recently, CodeBuild released a new set of environment types which can be found here:
LINUX_EC2,ARM_EC2andWINDOWS_EC2. The CodeBuild CDK code should be updated to reflect these new environment types.Use Case
Users can not create fleets with new environment types using CDK.
Proposed Solution
Add new environment types
LINUX_EC2,ARM_EC2andWINDOWS_EC2into file.Other Information
No response
Acknowledgements
CDK version used
Any
Environment details (OS name and version, etc.)
Any
The text was updated successfully, but these errors were encountered: