Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CloudFront] Distribution - Origin Groups #9109

Closed
njlynch opened this issue Jul 16, 2020 · 0 comments · Fixed by #9360
Closed

[CloudFront] Distribution - Origin Groups #9109

njlynch opened this issue Jul 16, 2020 · 0 comments · Fixed by #9360
Assignees
@skinny85
Labels
@aws-cdk/aws-cloudfront Related to Amazon CloudFront effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on.
Milestone
[DevPreview] Clou...

Comments

@njlynch
Copy link
Contributor

njlynch commented Jul 16, 2020

Create support for Origin Groups (fallback origin configurations) for the new Distribution construct.

Proposed Solution

See aws/aws-cdk-rfcs#171.

This is a 🚀 Feature Request
@njlynch njlynch added feature-request A feature should be added or improved. @aws-cdk/aws-cloudfront Related to Amazon CloudFront effort/medium Medium work item – several days of effort labels Jul 16, 2020
@njlynch njlynch self-assigned this Jul 16, 2020
@skinny85 skinny85 assigned skinny85 and unassigned njlynch Jul 24, 2020
@skinny85 skinny85 added the in-progress This issue is being actively worked on. label Jul 24, 2020
@skinny85 skinny85 mentioned this issue Jul 28, 2020
Merged
mergify bot pushed a commit that referenced this issue Jul 29, 2020
@skinny85
chore(cloudfront): small refactoring of the Origin API (#9281)
cbfdc15 
Change the Origin to an interface, from an abstract class, and change its `bind` protocol to return an `OriginBindConfig` interface.

This is in preparation for handling Origin Groups in #9109 - when time comes to handle Origin Groups, we will add a new (optional) property to `OriginBindConfig`, of type `CfnDistribution.OriginGroupProperty`, and handle it in `Distribution`.

BREAKING CHANGE: the property Origin.domainName has been removed

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
skinny85 added a commit to skinny85/aws-cdk that referenced this issue Jul 30, 2020
@skinny85
feat(cloudfront): add support for Origin Groups
3676e4a 
Fixes aws#9109
@skinny85 skinny85 mentioned this issue Jul 30, 2020
Merged
skinny85 added a commit to skinny85/aws-cdk that referenced this issue Jul 30, 2020
@skinny85
feat(cloudfront): add support for Origin Groups
e9babd7 
Fixes aws#9109
skinny85 added a commit to skinny85/aws-cdk that referenced this issue Jul 31, 2020
@skinny85
feat(cloudfront): add support for Origin Groups
c1ae63f 
Fixes aws#9109
skinny85 added a commit to skinny85/aws-cdk that referenced this issue Aug 3, 2020
@skinny85
feat(cloudfront): add support for Origin Groups
ab0a43f 
Fixes aws#9109
@mergify mergify bot closed this as completed in #9360 Aug 3, 2020
mergify bot pushed a commit that referenced this issue Aug 3, 2020
@skinny85
feat(cloudfront): add support for Origin Groups (#9360)
11e146c 
Fixes #9109

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
eladb pushed a commit that referenced this issue Aug 10, 2020
@skinny85
feat(cloudfront): add support for Origin Groups (#9360)
7c2446f 
Fixes #9109

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
curtiseppel pushed a commit to curtiseppel/aws-cdk that referenced this issue Aug 11, 2020
@skinny85
chore(cloudfront): small refactoring of the Origin API (aws#9281)
1cbfb8f 
Change the Origin to an interface, from an abstract class, and change its `bind` protocol to return an `OriginBindConfig` interface.

This is in preparation for handling Origin Groups in aws#9109 - when time comes to handle Origin Groups, we will add a new (optional) property to `OriginBindConfig`, of type `CfnDistribution.OriginGroupProperty`, and handle it in `Distribution`.

BREAKING CHANGE: the property Origin.domainName has been removed

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
curtiseppel pushed a commit to curtiseppel/aws-cdk that referenced this issue Aug 11, 2020
@skinny85
feat(cloudfront): add support for Origin Groups (aws#9360)
301fb52 
Fixes aws#9109

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skinny85 skinny85

Labels
@aws-cdk/aws-cloudfront Related to Amazon CloudFront effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on.
Projects
None yet
Milestone
[DevPreview] CloudFront 'Distribution...
Development

Successfully merging a pull request may close this issue.

feat(cloudfront): add support for Origin Groups skinny85/aws-cdk
3 participants
@skinny85 @njlynch @iliapolo