Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aws-rds] Support for joining a database instance to a domain #9869

Closed
1 of 2 tasks
ctaylor-osv opened this issue Aug 20, 2020 · 0 comments · Fixed by #9943
Closed
1 of 2 tasks

[aws-rds] Support for joining a database instance to a domain #9869

ctaylor-osv opened this issue Aug 20, 2020 · 0 comments · Fixed by #9943
Assignees
@skinny85
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database feature-request A feature should be added or improved. in-progress This issue is being actively worked on. needs-triage This issue or PR still needs to be triaged.

Comments

@ctaylor-osv
Copy link
Contributor

CloudFormation supports joining a database instance to a domain. It would be great if the CDK construct supported setting these properties, along with creating the necessary IAM role.

Use Case

We have a AWS Managed Microsoft AD and would like to be able to use Windows authentication for SQL users.

Proposed Solution

Add a domain property to the DatabaseInstanceNewProps interface and, when set, creates a new role that has the AWS managed policy AmazonRDSDirectoryServiceAccess and sets the Domain and DomainIAMRoleName properties on the underlying CloudFormation resource.

Other

This may need to be moved to the DatabaseInstanceSourceProps and related abstract class if you want to add validation to make sure that the engine type supports joining to a domain as, according to the link above, only MySQL, Microsoft SQL Server, Oracle, and PostgreSQL DB instances can be created in an Active Directory Domain.

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@ctaylor-osv ctaylor-osv added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 20, 2020
@github-actions github-actions bot added the @aws-cdk/aws-rds Related to Amazon Relational Database label Aug 20, 2020
ctaylor-osv added a commit to ctaylor-osv/aws-cdk that referenced this issue Aug 24, 2020
@ctaylor-osv
feat(rds): add support for joining instance to domain
b1779a7 
Added new properties to be able to join instance to a domain.

closes aws#9869
ctaylor-osv added a commit to ctaylor-osv/aws-cdk that referenced this issue Aug 24, 2020
@ctaylor-osv
feat(rds): add support for joining instance to domain
bfb0c6e 
Added new properties to be able to join instance to a domain.

closes aws#9869
@ctaylor-osv ctaylor-osv mentioned this issue Aug 24, 2020
Merged
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Aug 31, 2020
@mergify mergify bot closed this as completed in #9943 Sep 1, 2020
mergify bot pushed a commit that referenced this issue Sep 1, 2020
@ctaylor-osv
feat(rds): add support for joining instance to domain (#9943)
f2d77d1 
Added new properties to be able to join instance to a domain.

closes #9869


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skinny85 skinny85

Labels
@aws-cdk/aws-rds Related to Amazon Relational Database feature-request A feature should be added or improved. in-progress This issue is being actively worked on. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(rds): add support for joining instance to domain ctaylor-osv/aws-cdk
3 participants
@skinny85 @SomayaB @ctaylor-osv