Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): bootstrapping qualifier length not validated #10121

Merged
merged 3 commits into from
Sep 2, 2020
Merged

fix(cli): bootstrapping qualifier length not validated #10121

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0a4015a
fix(cli): bootstrapping qualifier length not validated
rix0rrr Sep 2, 2020
91d00b6
Update bootstrap-template.yaml
rix0rrr Sep 2, 2020
f8b1411
Merge branch 'master' into huijbers/qualifier-length
mergify[bot] Sep 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/aws-cdk/lib/api/bootstrap/bootstrap-template.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ Parameters:
Description: An identifier to distinguish multiple bootstrap stacks in the same environment
Default: hnb659fds
Type: String
# "cdk-(qualifier)-image-publishing-role-(account)-(region)" needs to be <= 64 chars
# account = 12, region <= 14, 10 chars for qualifier and 28 for rest of role name
AllowedPattern: "[A-Za-z0-9_-]{1,10}"
ConstraintDescription: Qualifier must be an alphanumeric identifier of at most 10 characters
PublicAccessBlockConfiguration:
Description: Whether or not to enable S3 Staging Bucket Public Access Block Configuration
Default: 'true'
Expand Down
2 changes: 1 addition & 1 deletion packages/aws-cdk/test/integ/cli/bootstrapping.integtest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { integTest } from './test-helpers';

jest.setTimeout(600_000);

const QUALIFIER = randomString();
const QUALIFIER = randomString().substr(0, 10);

beforeAll(async () => {
await prepareAppFixture();
Expand Down