feat(apigateway): autodetermine the private integration uri #10730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladb
previously requested changes
Oct 6, 2020
added 2 commits
October 8, 2020 14:39
When VPC Link is configured as a private integration on a Method, the 'uri' field is required. Without this the CloudFormation deployment fails with the error - 'Invalid integration URI specified'. Instead of switching this to just a synth time error, use the NLB DNS name when available. closes #10435
nija-at
force-pushed
the
nija-at/apigw-vpclinkuri-validation
branch
from
a48e34b to
1e87d57
Compare
eladb
approved these changes
Oct 12, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When VPC Link is configured as a private integration on a Method, the
'uri' field is required. Without this the CloudFormation deployment
fails with the error - 'Invalid integration URI specified'.
Instead of switching this to just a synth time error, use the NLB DNS
name when available.
closes #10435
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license