Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(redshift): add publiclyAccessible prop #11162

Merged
merged 5 commits into from
Oct 29, 2020
Merged

Conversation

alex9311
Copy link
Contributor

fixes #11161


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Oct 27, 2020

@mergify
Copy link
Contributor

mergify bot commented Oct 27, 2020

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@alex9311 alex9311 changed the title Update cluster to accept publiclyAccessible prop feat(redshift): add publiclyAccessible prop Oct 27, 2020
@alex9311 alex9311 force-pushed the patch-1 branch 2 times, most recently from 454c8d7 to 32a9032 Compare October 28, 2020 00:18
packages/@aws-cdk/aws-redshift/test/cluster.test.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-redshift/test/cluster.test.ts Outdated Show resolved Hide resolved
@njlynch njlynch self-assigned this Oct 28, 2020
@mergify mergify bot dismissed njlynch’s stale review October 28, 2020 18:18

Pull request has been modified.

@alex9311
Copy link
Contributor Author

thanks @njlynch , applied your suggestions and got all checks passing!

@mergify
Copy link
Contributor

mergify bot commented Oct 29, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 2d24de0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Oct 29, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 9f8a6de into aws:master Oct 29, 2020
@alex9311 alex9311 deleted the patch-1 branch October 29, 2020 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to Make Redshift Cluster Publicly Accessible [Redshift]
3 participants