Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(apigatewayv2-integrations): EventBridge PutEvents integration #13017
feat(apigatewayv2-integrations): EventBridge PutEvents integration #13017
Changes from all commits
0079639
a365938
56bf30e
875aac7
624347a
4a9ff6c
c47d775
87334b5
7572fad
8b654b4
7f163c4
17bf676
ac3721d
b817240
2d4d363
66cf35f
440187d
a88c5be
87e49fb
81912fb
f4d1fd8
4bded77
1ed9d20
f7a4dc5
494e981
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought this needs to be a valid JSON string, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this? Can you provide more details in the tsdoc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I go through this, something feels incorrect or odd here in terms of class modeling.
For one, the
targetAction
allows for other EventBridge APIs to be invoked butEventBridgeIntegrationRequestParameters
is very specific to thePutEvents
API.It's not clear to me if this class should be
EventBridgePutEventsIntegration
. I'm aware this is conflicting with my previous comment - #13017 (comment). Perhaps we may have to go back to the previous model.Second, the
resources
option allows customers to pass a set of ARNs. I would've assumed this would be the ARN of the APIGateway resource but it looks like this is configurable. When and why would this be done?I suppose more generally - what is/are the use cases that customers are expected to use this integration?
Finally (probably least important here), we probably do not need an additional nested
requestParameters
section. Flattening it might suffice.