chore: remove all @experimental annotation #14071
Conversation
|
|
NetaNir
force-pushed
the
neta/remove-exp-2
branch
from
fc7beb0 to
bcde084
Compare
| @@ -869,7 +867,6 @@ export class CfnAuthorizerV2 extends cdk.CfnResource implements cdk.IInspectable | |||
| * | |||
| * @param inspector - tree inspector to collect and process attributes | |||
| * | |||
| * @stability experimental | |||
| */ | |||
| public inspect(inspector: cdk.TreeInspector) { | |||
| @@ -6,7 +6,6 @@ export enum Mode { | |||
| } | |||
|
|
|||
| /** | |||
| * @experimental | |||
There was a problem hiding this comment.
@rix0rrr @NetaNir which APIs exactly are we exporting from the CDK CLI? Are we really ready to call these stable? I am concerned that this will signal to folks that they can use the CLI as a library and will bound is to this APIs... I'd hold off with removing the @experimental tags here (the CLI is also not part of the aws-cdk-lib, so I don't think this is required for v2)
There was a problem hiding this comment.
@eladb But it is a part of the AWS CDK, and I don't think there will be any notable distinction in our v2 announcements between the CLI and the framework, at least not in a way that will be easy for customers to understand. If we break a public API in the CLI post v2 GA, it will most likely be perceived as not keeping our stability promise. In all honesty, I don't think this annotation was ever understood/noticed by customers.
| @@ -522,7 +522,6 @@ export class ConstructNode { | |||
| * Remove the child with the given name, if present. | |||
| * | |||
| * @returns Whether a child with the given name was deleted. | |||
| * @experimental | |||
There was a problem hiding this comment.
Since some files do not exist in v2-main (like this one), this will result in some merge conflicts. @NetaNir can you please make sure to do a forward merge to v2-main immediately after this is merged so that conflicts will be limited to this change and not intermingled with lots of future changes? (copy @nija-at)
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Add a lint rule that disallow the use of @experimental in stable module. Ideally we would do the same for experimental modules, but for these, jsii marks all properties as experimental. Since we only care about stable modules, this is sufficient. Im open to other suggestion as well. Should only be merged after #14071 which removes all experimental API. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
As a part of v2 efforts we are stabilizing all `@experimental` APIs from stable modules. A separate PR aws#14070, adds a lint rule that ban the usage of @experimental. #### Note on experimental modules The removal of the @experimental annotation from APIs in experimental modules does not change their stability, as it determined only by their containing module stability. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Add a lint rule that disallow the use of @experimental in stable module. Ideally we would do the same for experimental modules, but for these, jsii marks all properties as experimental. Since we only care about stable modules, this is sufficient. Im open to other suggestion as well. Should only be merged after aws#14071 which removes all experimental API. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
As a part of v2 efforts we are stabilizing all `@experimental` APIs from stable modules. A separate PR aws#14070, adds a lint rule that ban the usage of @experimental. #### Note on experimental modules The removal of the @experimental annotation from APIs in experimental modules does not change their stability, as it determined only by their containing module stability. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Add a lint rule that disallow the use of @experimental in stable module. Ideally we would do the same for experimental modules, but for these, jsii marks all properties as experimental. Since we only care about stable modules, this is sufficient. Im open to other suggestion as well. Should only be merged after aws#14071 which removes all experimental API. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
As a part of v2 efforts we are stabilizing all
@experimentalAPIs from stable modules. A separate PR #14070, adds a lint rule that ban the usage of @experimental.Note on experimental modules
The removal of the @experimental annotation from APIs in experimental modules does not change their stability, as it determined only by their containing module stability.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license