feat(kinesisfirehose): supports Kinesis data stream source for delivery stream #15836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roperty type and use local var instead
…adeline-k/feat/kinesisfirehose-dataprocessors
…deline-k/feat/kinesisfirehose-backup
…esisfirehose-backup
|
|
Base automatically changed from
madeline-k/feat/kinesisfirehose-backup
to
master
July 30, 2021 18:22
madeline-k
reviewed
Aug 3, 2021
Comment on lines
+21
to
+32
| const mockS3Destination: firehose.IDestination = { | ||
| bind(_scope: constructs.Construct, _options: firehose.DestinationBindOptions): firehose.DestinationConfig { | ||
| const bucketGrant = bucket.grantReadWrite(role); | ||
| return { | ||
| extendedS3DestinationConfiguration: { | ||
| bucketArn: bucket.bucketArn, | ||
| roleArn: role.roleArn, | ||
| }, | ||
| dependables: [bucketGrant], | ||
| }; | ||
| }, | ||
| }; |
There was a problem hiding this comment.
Is this duplicated with the other integration test? Can you make one shared construct for this for the unit and integ tests?
There was a problem hiding this comment.
I think for literacy purposes, I'd rather keep this duplicated
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
david-doyle-as24
pushed a commit
to david-doyle-as24/aws-cdk
that referenced
this pull request
Sep 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #15500
closes #10783
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license