feat(lambda-nodejs): typescript emitDecoratorMetadata support

[hassanazharkhan]

closes #13767

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[mergify]

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

[hassanazharkhan]

@nija-at Could you please spare sometime to review this?

[jogold]

Hey @hassanazharkhan, from the esbuild doc I see there is some support for experimental decorators already? https://esbuild.github.io/content-types/#typescript

Is it different?

[hassanazharkhan]

Hey @hassanazharkhan, from the esbuild doc I see there is some support for experimental decorators already? https://esbuild.github.io/content-types/#typescript

Is it different?

Hi @jogold, Thank you for your reply, it is indeed different, I would suggest have a look on the following issue evanw/esbuild#1597 for clarification.

Yes, esbuild does support decorators but doesn't support emitDecoratorsMetadata so in this I tried to cover that missing part by transpling ts files using tsc and then forward the transpiled file to esbuild for bundling.

[nija-at]

@jogold - Thanks for jumping in.
I have little exposure to eslint, would appreciate if you can handle this pull request on my behalf.

[hassanazharkhan]

@jogold addressed your comments, would appreciate another pass!

[jogold]

Question: what workaround are you currently using to use emitDecoratorMetadata in your projects? Are you compiling your whole project with a single tsc run and then pointing the entry to the .js file? Do you have different tsconfig.json files for different handlers and have to run tsc multiple times?

[hassanazharkhan]

Question: what workaround are you currently using to use emitDecoratorMetadata in your projects? Are you compiling your whole project with a single tsc run and then pointing the entry to the .js file? Do you have different tsconfig.json files for different handlers and have to run tsc multiple times?

As discussed offline, I'm using single tsc command to bundle all of my code and then pointing the entry to compiled .js file outputted from tsc.

[hassanazharkhan]

@jogold would appreciate another pass!

[jogold]

@nija-at I think this is now ready for your review, can you take a look? Thx.

README and naming to be discussed maybe.

[nija-at]

Thanks for the PR @hassanazharkhan and the review @jogold.

Just some comments from me around docs.

Pull request has been modified.

[hassanazharkhan]

Thanks, @nija-at for the review, would appreciate another pass!

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
• Commit ID: a40dc46
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).