chore: namespace all private packages #16689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to remove any risk of supply-chain attacks leveraging naming collisions with any of our private-only packages, move all of them into the `@aws-cdk/` namespace, so that no third party can possibly seize one of these names. Also, normalized the order of dependencies in `package.json` files so they are consistently alphanumerically ordered.
|
|
otaviomacedo
approved these changes
Sep 28, 2021
RomainMuller
force-pushed
the
rmuller/private-packages
branch
3 times, most recently
from
4857d47 to
510daee
Compare
RomainMuller
force-pushed
the
rmuller/private-packages
branch
2 times, most recently
from
19abc19 to
d9ffa77
Compare
…kages # Conflicts: # packages/@aws-cdk/aws-applicationautoscaling/package.json # packages/@aws-cdk/aws-chatbot/package.json # packages/@aws-cdk/aws-codecommit/package.json # packages/@aws-cdk/aws-codepipeline/package.json # packages/@aws-cdk/aws-ecr-assets/package.json # packages/@aws-cdk/aws-ecr/package.json # packages/@aws-cdk/aws-logs/package.json # packages/@aws-cdk/aws-s3-assets/package.json # packages/@aws-cdk/aws-s3/package.json # packages/@aws-cdk/aws-sqs/package.json # packages/@aws-cdk/aws-ssm/package.json
RomainMuller
force-pushed
the
rmuller/private-packages
branch
from
d9ffa77 to
de8a77d
Compare
RomainMuller
force-pushed
the
rmuller/private-packages
branch
from
3bdd3d0 to
d109026
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
In order to remove any risk of supply-chain attacks leveraging naming collisions with any of our private-only packages, move all of them into the `@aws-cdk/` namespace, so that no third party can possibly seize one of these names. Also, normalized the order of dependencies in `package.json` files so they are consistently alphanumerically ordered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to remove any risk of supply-chain attacks leveraging naming
collisions with any of our private-only packages, move all of them into
the
@aws-cdk/namespace, so that no third party can possibly seize oneof these names.
Also, normalized the order of dependencies in
package.jsonfiles sothey are consistently alphanumerically ordered.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license