[WIP] fix(core): self contained CDK_OUTDIR #1895
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change enables each construct in the tree to participate in synthesis by overriding the "synthesize" method and emitting files to the session directory. It is a small step towards generalizing how synthesis artifacts are being produced, built and deployed by the CDK. This change moves the code that synthesizes a CloudFormation template from a CDK stack to the `Stack` class and emits a `.template.json` file for each stack. The CLI hasn't been changed to work with these new files yet, so the output of this file is ALSO included in the main manifest (defined `cxapi.OUTFILE_NAME`), which is the only file currently being read by the CLI.
This test is referred as example in the [Cloudformation README](https://github.com/awslabs/aws-cdk/blob/master/packages/%40aws-cdk/aws-cloudformation/README.md). But the example doesn't do what it intended. Without specifying the runOrder the `pipelineExecuteChangeSetAction` will be triggered immediately without change set being populated, which will lead to deployment failure. After adding the `runOrder` the 3 actions will run in order and only be deployed after manual approval.
When running in CI, try to pull the latest image first and use it as cache for the build. CI is detected by the presence of the `CI` environment variable. Closes #1748
Adds a handler to enable raw message delivery on SNS topic subscriptions.
Forgot to modify the signatures on the interface when I updated the base class. This is now fixed.
Changed "documentation" to "reference documentation" in description.
If we report synthesis errors, they should only prevent the affected stack from deploying; right now, since they are checked during the synthesis step, they would abort the entire toolkit run regardless of whether they would be selected or not. Makes it possible to do region-dependent verification. Fixes #1784. ALSO IN THIS COMMIT If the 'cdk synth' output goes to the screen, don't automatically select upstream stacks for synthesis (as that would lead to an immediate error). Fixes #1783.
Fix usage of application and network target groups in languages without structural typing, such as Java and C#. Fixes #1799.
`SecretParameter` was being used incorrectly and it did not pass typechecking. The type error was: ``` Type 'SecretParameter' is missing the following properties from type 'Secret': resolve, toJSON, toList ```
added 7 commits
February 26, 2019 19:00
eladb
changed the title
rix0rrr
approved these changes
Feb 27, 2019
| ? this.artifactName | ||
| : path.join(this.artifactName, path.basename(props.path)); | ||
|
|
||
| this.relativePath = `./${this.relativePath}`; // prefix with './' |
There was a problem hiding this comment.
Why prefix with ./? By traditional filesystem convention, any path that doesn't start with / is already relative.
If you're thinking about NodeJS, they reason they do it is because they also want to support a global registry of packages, and they want to disambiguate:
require('bla'); // Is this a global 'bla' or a local 'bla.js'?I don't think we need that feature, and even if we did we could get it by prepending a special namespace like builtin:bla.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change copies all assets referenced in CDK code to the CDK_OUTDIR as artifacts (see #1893) so that the output directory is now self-contained. This is part of the design for generalizing artifacts #1893.
It also modifies the path metadata (both
aws:asset:pathandcdk:asset:path) to use relative paths instead of absolute paths, which is a breaking change in respect to the toolkit.Fixes #1716
BREAKING CHANGE: Users will need to upgrade their toolkit to v0.25.0 or above if their CDK applications use assets. Otherwise the toolkit will likely not find asset files during deployment.
Remaining work:
CDK_OUTDIRa persistent directory (emitted under the project directory or something). Otherwise, tools that wish to access assets won't be able to find them because the temporary directory will disappear.