-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(stepfunctions-tasks): migrate from deprecated batch properties #19298
Conversation
@peterwoodworth Since |
I had considered that @kaizen3031593, and actually went with deprecating the properties at first in exchange for what you proposed - but since this change is within the stepfunctions-tasks module I had decided to stick with the easier change at first to see what you would say. Still, since this change is within a stable module that would require deprecation instead of outright removal, right? |
Whoops I thought this was in |
Let me know if you'd like me to go with deprecation 👍🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
fixes #18993 + update integ tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license