-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): cdk deploy --method=direct
is faster
#22079
Conversation
CloudFormation changeset creation may take up a significant amount of time in a deployment, and isn't necessary anymore since the `AUTO_EXPAND` capability has been added. Add a new command-line option, `cdk deploy --method=direct` which skips changeset creation and provides faster deployments (6-15 seconds, dependending on the complexity of the change set). This comes at the expense of being able to provide progress information, since we won't know how many resources will need to be updated anymore before we start. This feature is opt-in until we can establish that it's safe and desirable in all cases, but it can be made the default for your shell by putting: ``` export CDK_METHOD=direct ``` In your shell initialization script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty cool!
This feature is opt-in until we can establish that it's safe and desirable in all cases, but it can be made the default for your shell by putting:
export CDK_METHOD=direct
In your shell initialization script.
You mention this in the PR description, but I don't see it implemented anywhere. Can you update the description if this was dropped?
Just for my own benefit I'm curious what changed with AUTO_EXPAND
(CAPABILITY_AUTO_EXPAND
?) that made this possible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Pull Request Linter fails with the following errors:
❌ Features must contain a change to an integration test file and the resulting snapshot.
PRs must pass status checks before we can provide a meaningful review.
Apparently (according to James) it was always possible. |
Pull Request updated. Dissmissing previous PRLinter Review.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
🤯 |
@rix0rrr @corymhall looking at CreateStack documentation, Do I understand correctly that his pull request is not as much about |
CloudFormation changeset creation may take up a significant amount of time in a deployment, and isn't necessary anymore since the `AUTO_EXPAND` capability has been added. Add a new command-line option, `cdk deploy --method=direct` which skips changeset creation and provides faster deployments (6-15 seconds, dependending on the complexity of the change set). This comes at the expense of being able to provide progress information, since we won't know how many resources will need to be updated anymore before we start. This feature is opt-in until we can establish that it's safe and desirable in all cases, but it can be made the default for your shell by putting: ``` export CDK_METHOD=direct ``` In your shell initialization script. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
CloudFormation changeset creation may take up a significant amount of time in a deployment, and isn't necessary anymore since the
AUTO_EXPAND
capability has been added.Add a new command-line option,
cdk deploy --method=direct
which skips changeset creation and provides faster deployments (6-15 seconds, dependending on the complexity of the change set).This comes at the expense of being able to provide progress information, since we won't know how many resources will need to be updated anymore before we start.
This feature is opt-in until we can establish that it's safe and desirable in all cases, but it can be made the default for your shell by putting:
In your shell initialization script.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license