fix(integ-tests): allow multiple AwsApiCalls with the same action and different parameters #25241
Conversation
|
|
github-actions
bot
added
beginning-contributor
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
guiyom-e
changed the title
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
guiyom-e
force-pushed
the
fix/multiple-aws-api-call
branch
from
a250089 to
94900ec
Compare
| @@ -59,7 +59,12 @@ export class DeployAssert extends Construct implements IDeployAssert { | |||
| } | |||
|
|
|||
| public awsApiCall(service: string, api: string, parameters?: any, outputPaths?: string[]): IApiCall { | |||
| return new AwsApiCall(this.scope, `AwsApiCall${service}${api}`, { | |||
| let hash = 'NoParameter'; | |||
There was a problem hiding this comment.
| let hash = 'NoParameter'; | |
| let hash = ''; |
Can we default to no hash instead.
There was a problem hiding this comment.
Yes, sure, and it's simpler! I've just pushed changes.
guiyom-e
force-pushed
the
fix/multiple-aws-api-call
branch
from
94900ec to
8a6724c
Compare
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
@corymhall the merge train github action fails with error Note that I checked the "Allow edits and access to secrets by maintainers" checkbox, so the action should be able to rebase itself. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This PR allows multiple AwsApiCalls with the same action and different parameters.
Closes #25014
To be able to test the new behavior, a new integration test has been added in aws-redshift-alpha package.
Next possible step (to be discussed): add an optional
callNumberinawsApiCallmethod to be able to use this method twice with the same action and same parameters.