chore(eks): fix integ tests #25448
Merged
chore(eks): fix integ tests #25448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
bug
|
|
aws-cdk-automation
added
the
pr/needs-community-review
|
Indeed, those two things were not going well, and this integration was stalled. |
corymhall
approved these changes
May 5, 2023
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This was referenced May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes 2 integ tests from aws-eks.
integ.eks-helm-assetsis failing because 2 helm charts are trying to install with the same release name and this is failing with race condition. This PR replaces one of them with another helm chart from ACK to avoid that and ensures the integ test will succeed.integ.eks-service-account-sdk-callis missingpackage.jsonandsdk-call.jsas described in eks: missing package.json in the integ test #25178 anddocker buildis failing due to missing files. We restored them from v2.72.1 with minor update on the test.Now both integ tests can successfully run with no error.
Closes #25438 #25178
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license