Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lambda): provide support for AWS Parameters and Secrets Extension for Lambda #25928

Merged
merged 55 commits into from
Jun 12, 2023

Conversation

colifran
Copy link
Contributor

@colifran colifran commented Jun 10, 2023

This PR provides support for the AWS Parameters and Secrets Extension for Lambda functions. This extension will allow users to retrieve and cache AWS Secrets Manager secrets and AWS Parameter Store parameters in Lambda functions without using an SDK.

Note: Previous PR results in the go build breaking. This removed the circular dependency causing the go build to break:

[jsii-pacmak] [INFO] Found 1 modules to package
[jsii-pacmak] [INFO] Packaging NPM bundles
[jsii-pacmak] [INFO] Loading jsii assemblies and translations
[jsii-pacmak] [INFO] Packaging 'go' for aws-cdk-lib
[jsii-pacmak] [INFO] go finished
[jsii-pacmak] [INFO] Packaged. go (54.9s) | npm pack (5.4s) | load jsii (0.5s) | cleanup (0.0s)

Closes #23187


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

colifran added 30 commits May 19, 2023 15:13
…s and added an enum for params and secrets logging level

Signed-off-by: Francis <[email protected]>
…d environment variables based on config

Signed-off-by: Francis <[email protected]>
…ce and added permissions to attachParametersAndSecretsExtension method

Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
…iables as part of the extension

Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
… region-info to include version

Signed-off-by: Francis <[email protected]>
Signed-off-by: Francis <[email protected]>
@gitpod-io
Copy link

gitpod-io bot commented Jun 10, 2023

@aws-cdk-automation aws-cdk-automation requested a review from a team June 10, 2023 00:06
@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1 labels Jun 10, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 10, 2023
@colifran colifran added the pr/do-not-merge This PR should not be merged at this time. label Jun 10, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 10, 2023
@colifran colifran removed the pr/do-not-merge This PR should not be merged at this time. label Jun 10, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 12, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 568799c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 4a3903f into main Jun 12, 2023
@mergify mergify bot deleted the colifran/params-and-secrets-lambda-extension branch June 12, 2023 12:02
@mergify
Copy link
Contributor

mergify bot commented Jun 12, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(lambda): Make it easy to use "AWS Parameters and Secrets Lambda Extension" with Lambda Functions
3 participants