fix(ecr): error handling compatible with aws sdk v3

[tmokmss]

Just fixing this in the same way as #26433

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[tmokmss]

Exemption Request
I think unit testing is enough for this change

[MrArnoldPalmer]

Looks like the app-staging-synthesizer-alpha package has a dependent integ snapshot that needs to be updated as well, otherwise I think this looks fine. Thank you for the catch @tmokmss, we made sure we caught all the error.code checks but error.name was available on only some errors in sdk v2 I'm assuming?

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[tmokmss]

@MrArnoldPalmer
I misunderstood this would not work, but it seems it does 🤦

This change is backward compatible—all the existing error handling code will still work. You can still assert the error by the name value. https://aws.amazon.com/blogs/developer/service-error-handling-modular-aws-sdk-js/

I guess instanceof is preferable way to handle errors in sdk v3 though.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: d4589f6
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).