-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(release): 2.91.0 #26709
Merged
Merged
chore(release): 2.91.0 #26709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…26650) Fixes some issues on Glue Job synth time validation: - `maxCapacity` can be specified for PythonShell jobs with Glue Version 2.0+ and should be either 0.0625 or 1 (defaults to 0.0625) - Validation was not working when using `GlueVersion.of()` and `JobType.of()` - PythonShell jobs supports GlueVersion 3.0 Closes #26620. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…incorrect (#26626) Existing [documentation](https://docs.aws.amazon.com/AmazonCloudWatch/latest/monitoring/Lambda-Insights-extension-versionsARM.html#Lambda-Insights-extension-ARM-1.0.229.0) Closes #26615 . ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
AWS Service Spec packages to latest versions.
Add support for Aurora Engine Version 3_04_0. AWS Release notes: https://docs.aws.amazon.com/AmazonRDS/latest/AuroraMySQLReleaseNotes/AuroraMySQL.Updates.3040.html
The docs for `NodeJsFunction` say `runtime` defaults to `NODEJS_14_X` but the code defaults to `lambda.Runtime.NODEJS_18_X` (on `function.ts:104`) Closes #26459. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Adds a set of L2s to appconfig. For more information, see the [RFC](https://github.com/aws/aws-cdk-rfcs/blob/master/text/0499-appconfig-constructs.md). ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…r instances with secret credentials (#26647) Calling `grantConnect` on instances with secret credentials not specifying the user was causing the deploy to fail because the secret was not resolved. This fix solves the bug. Closes #26603. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Cloudformation recently [added support](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/intrinsic-function-reference-findinmap-enhancements.html) for a default value in the FindInMap intrinsic function. This adds that support. Closes #26125. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Fixes the cross region zone delegation custom resource in route53 by reverting to using the v2 aws-sdk. This requires reverting the runtime to use Node16 until we figure out the correct usage of the v3 sdk. At this point I suspect it is an issue with the SDK but I have been unable to reliably reproduce the bug, regardless of the parent or child stack being in an opt-in region and vice versa Fixes: #26593 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Ran npm-check-updates and yarn upgrade to keep the `yarn.lock` file up-to-date.
As per title - adding the scaffold to begin work on Ground Station alpha constructs. This work has been discussed with bar raiser @TheRealAmazonKendra ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
When `authFlows` is not defined `UserPoolClient` will support ALLOW_REFRESH_TOKEN_AUTH, ALLOW_USER_SRP_AUTH, and ALLOW_CUSTOM_AUTH. [Link](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-cognito-userpoolclient.html#cfn-cognito-userpoolclient-explicitauthflows) to CFN docs. Closes #26680. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…7.43 (#26699) Add support for RDS MySQL minor versions of 8.0.34 and 5.7.43 https://aws.amazon.com/about-aws/whats-new/2023/08/amazon-rds-mysql-new-minor-versions/ https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/MySQL.Concepts.VersionMgmt.html ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
… false (#26676) Currently, trigger is re-executed every time when the handler function code or configuration changes even if executeOnHandlerChange is set to false. This is because executeOnHandlerChange prop is never used in the current implementation. This PR solves the issue by referring executeOnHandlerChange prop and skipping function invocation when executeOnHandlerChange is set to false. Closes #25939 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
#26648) Allowed origins for CORS preflight were treated like regular expressions in the checking condition. For example, with this spec: ``` new apigateway.RestApi(this, 'api', { defaultCorsPreflightOptions: { allowOrigins: ['https://www.firstorigin.com', 'https://www.secondorigin.com'], } }) .root .addResource('hello') .addMethod('GET', new apigateway.MockIntegration({})); ``` Calling: ``` http OPTIONS https://xxx.execute-api.xxx.amazonaws.com/prod/hello "Origin: https://wwwXsecondorigin.com" ``` The response header would include the header (allowing the invalid origin from the request): ``` Access-Control-Allow-Origin: https://wwwXsecondorigin.com ``` This fix solves the issue. Closes #26623. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Hello maintainers This is my first PR, so all feedback is welcome. This change adds support for the `--quiet` flag within cdk diff command, for users that would not like the following messages 'Stack <name>' and 'There were no differences' to be silenced for stacks which do not have *any* identified differences. The request was made by @nomike in the #26526, I simply followed the very well detailed description. The change follows similar structure to existing command and how they are passed, I have also added to the README as per the contributing guidelines. Before submitting I have. - Built the packages & linted them - Ran unit tests for the entire module - Ran all integration tests in the suite from `@aws-cdk-testing/cli-integ/bin/run-suite -a cli-integ-tests` - E2E tested by launching my small stack in account and executing diffs on it from my build. Closes #26526 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
There weren't any examples for `AwsApiCall` in the document other than the Overview. This commit adds examples to the document of `AwsApiCall` and it helps users understand the usage. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…26704) Breaks our build. I think it is because there is nothing in `index.ts` but this does not seem like a big enough pr to block a release over, so am reverting. ``` npx tsc ts-import.ts(18,51): error TS2306: File '/tmp/tmp.QUQUtYehRM/node_modules/@aws-cdk/aws-groundstation-alpha/lib/index.d.ts' is not a module.</span> ``` New packages should always run through the test pipeline before merge.
Because of a mistake introduced into the SAM schema, the `AlexaSkill` event type doesn't have any required properties anymore. When the `CfnFunction` is trying all the different event types in the type union that it supports, it will go through every type in alphabetical order and pick the first type that doesn't fail its validation. After the schema change, the first type (`Alexa` which starts with an `A`) would therefore accept all types: no required fields, and for JavaScript compatibility purposes we allow superfluous fields, and so we pick a type that doesn't render anything. This change reorders the alternatives in the union such that stronger types are tried first. `HttpApiEvent` and `AlexaSkillEvent` both have no required properties, and this now reverses the problem: `AlexaSkillEvent` can no longer be specified because `HttpApiEvent` will match first. But that's the more common use case, so better for now, while we wait for the spec fix to come in, to prefer the HTTP API. Relates to #26637. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
jsii 1.86.0 and 1.86.1 have a few regressions and we do not want to wait to release 1.86.2 before releasing cdk. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…granting S3 access (#26696) The `SparkUIProps.prefix` attribute of `glue.Job` now has a consistent format, is validated, and the bucket ReadWrite role is only given permissions to the folder of the bucket specified by the `prefix` if provided. Adds a suggested format for the prefix: `/foo/bar` and throws and error if the prefix does not start with a `/` or ends without a `/`. This may be a breaking change for users who configured their prefix in a style different than this enforces. However, I believe it is the correct standardization going forward. Closes #19862. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
aws-cdk-automation
added
auto-approve
pr/no-squash
This PR should be merged instead of squash-merging it
labels
Aug 10, 2023
aws-cdk-automation
had a problem deploying
to
test-pipeline
August 10, 2023 18:37 — with
GitHub Actions
Failure
kaizencc
reviewed
Aug 10, 2023
kaizencc
had a problem deploying
to
test-pipeline
August 10, 2023 18:40 — with
GitHub Actions
Failure
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be automatically updated and merged without squashing (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See CHANGELOG