Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ecs-patterns): ScheduledFargateTaskProps is exposing unused props from FargateServiceBaseProps #26737

Merged
merged 5 commits into from
Aug 18, 2023
Merged

chore(ecs-patterns): ScheduledFargateTaskProps is exposing unused props from FargateServiceBaseProps #26737

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
744eab6
chore(ecs-patterns): ScheduledFargateTaskProps was exposing unused pr…
lpizzinidev Aug 12, 2023
37f7454
added annotation warnings for unused properties
lpizzinidev Aug 18, 2023
aa32a98
fix: import ordering
lpizzinidev Aug 18, 2023
a97a0d4
Merge branch 'main' into gh-26702
lpizzinidev Aug 18, 2023
4b61e92
Merge branch 'main' into gh-26702
mergify[bot] Aug 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions packages/aws-cdk-lib/aws-ecs-patterns/lib/fargate/scheduled-fargate-task.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
import { Construct } from 'constructs';
import { FargateTaskDefinition } from '../../../aws-ecs';
import { FargatePlatformVersion, FargateTaskDefinition } from '../../../aws-ecs';
import { EcsTask } from '../../../aws-events-targets';
import { FargateServiceBaseProps } from '../base/fargate-service-base';
import { ScheduledTaskBase, ScheduledTaskBaseProps, ScheduledTaskImageProps } from '../base/scheduled-task-base';

/**
* The properties for the ScheduledFargateTask task.
*/
export interface ScheduledFargateTaskProps extends ScheduledTaskBaseProps, FargateServiceBaseProps {
export interface ScheduledFargateTaskProps extends ScheduledTaskBaseProps {
/**
* The properties to define if using an existing TaskDefinition in this construct.
* ScheduledFargateTaskDefinitionOptions or ScheduledFargateTaskImageOptions must be defined, but not both.
Expand All @@ -24,6 +24,16 @@ export interface ScheduledFargateTaskProps extends ScheduledTaskBaseProps, Farga
*/
readonly scheduledFargateTaskImageOptions?: ScheduledFargateTaskImageOptions;

/**
* The platform version on which to run your service.
*
* If one is not specified, the LATEST platform version is used by default. For more information, see
* [AWS Fargate Platform Versions](https://docs.aws.amazon.com/AmazonECS/latest/developerguide/platform_versions.html)
* in the Amazon Elastic Container Service Developer Guide.
*
* @default Latest
*/
readonly platformVersion?: FargatePlatformVersion;
}

/**
Expand Down Expand Up @@ -89,7 +99,7 @@ export class ScheduledFargateTask extends ScheduledTaskBase {
}

// Use the EcsTask as the target of the EventRule
this.task = new EcsTask( {
this.task = new EcsTask({
cluster: this.cluster,
taskDefinition: this.taskDefinition,
taskCount: this.desiredTaskCount,
Expand Down