feat(stepfunctions): adding custom state name prop #27306
Conversation
github-actions
bot
added
effort/small
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
SankyRed
changed the title
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
There was a problem hiding this comment.
Can you try again with the title? Couple things:
- this is a feature, not a chore. if you feel like you need exemptions for integ tests, you can add the relevant labels yourself.
- standard is to not capitalize words
- since you are working in a particular module, the standard is to include the module name in the title (i.e.
feat(stepfunctions):) - try to rework the title to be more descriptive and describe the feature that has been added. if you've followed the other steps we're now at "feat(stepfunctions): adding custom state name prop". I don't think people who read the title will immediately know where the custom state name prop can be added.
SankyRed
changed the title
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
SankyRed
force-pushed
the
SankyRed/Allow-custom-state-names
branch
2 times, most recently
from
010de85 to
1163071
Compare
SankyRed
added
the
pr-linter/exempt-integ-test
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
SankyRed
force-pushed
the
SankyRed/Allow-custom-state-names
branch
4 times, most recently
from
127fb18 to
b1b8491
Compare
SankyRed
force-pushed
the
SankyRed/Allow-custom-state-names
branch
from
b1b8491 to
ba8ef10
Compare
SankyRed
force-pushed
the
SankyRed/Allow-custom-state-names
branch
from
e7813c1 to
146819a
Compare
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Closes #23532
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license